Add multi project test coverage to StableMasterHealthIndicatorServiceTests - #155686
Open
joshua-adams-1 wants to merge 3 commits into
Open
Add multi project test coverage to StableMasterHealthIndicatorServiceTests#155686joshua-adams-1 wants to merge 3 commits into
joshua-adams-1 wants to merge 3 commits into
Conversation
…Tests The health indicator is being made multi-project aware. The `master_is_stable` indicator is already cluster-wide, and so requires no changes. This change adds extra test coverage for the `master_is_stable` indicator on a multi-project cluster.
joshua-adams-1
added
>non-issue
:Distributed/Health
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates StableMasterHealthIndicatorServiceTests to exercise the master_is_stable health indicator in a multi-project cluster-state context, ensuring the indicator remains cluster-wide and is not affected by multi-project metadata/routing state.
Changes:
- Build test
ClusterStatewith multipleProjectMetadataentries. - Build a matching
GlobalRoutingTablecontaining per-project empty routing tables. - Wire the new multi-project
metadataandroutingTableinto the test cluster-state builder used across the suite.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joshua-adams-1
marked this pull request as ready for review
August 2, 2026 09:39
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The health indicator is being made multi-project aware. The
master_is_stableindicator is already cluster-wide, and so requires no changes. This change adds extra test coverage for themaster_is_stableindicator on a multi-project cluster.