Skip to content

WIP - KQL non-quoted spaces parsing support#6388

Draft
eric-forte-elastic wants to merge 5 commits into
mainfrom
6282-dac-export-rules-fails-to-export-kql-rules-when-spaces-are-not-quoted
Draft

WIP - KQL non-quoted spaces parsing support#6388
eric-forte-elastic wants to merge 5 commits into
mainfrom
6282-dac-export-rules-fails-to-export-kql-rules-when-spaces-are-not-quoted

Conversation

@eric-forte-elastic

Copy link
Copy Markdown
Contributor

Pull Request

Issue link(s):

Summary - What I changed

How To Test

Checklist

  • Added a label for the type of pr: bug, enhancement, schema, maintenance, Rule: New, Rule: Deprecation, Rule: Tuning, Hunt: New, or Hunt: Tuning so guidelines can be generated
  • Added the meta:rapid-merge label if planning to merge within 24 hours
  • Secret and sensitive material has been managed correctly
  • Automated testing was updated or added to match the most common scenarios
  • Documentation and comments were added for features that require explanation

Contributor checklist

@eric-forte-elastic eric-forte-elastic added bug Something isn't working patch labels Jul 6, 2026
@eric-forte-elastic eric-forte-elastic self-assigned this Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Bug - Guidelines

These guidelines serve as a reminder set of considerations when addressing a bug in the code.

Documentation and Context

  • Provide detailed documentation (description, screenshots, reproducing the bug, etc.) of the bug if not already documented in an issue.
  • Include additional context or details about the problem.
  • Ensure the fix includes necessary updates to the release documentation and versioning.

Code Standards and Practices

  • Code follows established design patterns within the repo and avoids duplication.
  • Ensure that the code is modular and reusable where applicable.

Testing

  • New unit tests have been added to cover the bug fix or edge cases.
  • Existing unit tests have been updated to reflect the changes.
  • Provide evidence of testing and detecting the bug fix (e.g., test logs, screenshots).
  • Validate that any rules affected by the bug are correctly updated.
  • Ensure that performance is not negatively impacted by the changes.
  • Verify that any release artifacts are properly generated and tested.
  • Conducted system testing, including fleet, import, and create APIs (e.g., run make test-cli, make test-remote-cli, make test-hunting-cli)

Additional Checks

  • Verify that the bug fix works across all relevant environments (e.g., different OS versions).
  • Confirm that the proper version label is applied to the PR patch, minor, major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DaC] export-rules Fails to Export KQL rules when spaces are not quoted

1 participant