Repository navigation
[8.19] fix(sharepoint): add compact site-group DLS mode to reduce ACL memory (#4396) - #4501
Merged
Merged
Conversation
Backport #4396 for the monolithic 8.19 SharePoint Online connector layout.
erikcurrin-elastic
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backported from #4396
Part of https://github.com/elastic/chat-program/issues/47.
Auto-backport to
8.19failed with cherry-pick conflicts because this branch still uses the monolithicconnectors/sources/sharepoint_online.pylayout (not thesharepoint/sharepoint_online/package onmain). Changes were manually adapted from #4396; behaviour matches the merged main PR.Adds
expand_site_group_members(defaulttrue) for compact site-group DLS tokens on documents, ACL-sync membership indexing, and identity enrichment when compact mode is enabled.Backport notes
connectors/sources/sharepoint_online.py(client + datasource + helpers).tests/sources/.expand_site_group_members: Add SharePoint Online expand_site_group_members RCF kibana#288070 (unchanged from main).Test plan
pytest tests/sources/test_sharepoint_online.py -k "site_group or guest_user or compact"Release Note
SharePoint Online document-level security can store compact site-group tokens on documents instead of expanding every site group member onto each record, reducing memory use for large site groups. Disable Expand site group members to enable compact mode. The default preserves the previous behavior. Changing the setting requires a full content sync and access control sync.