Repository navigation
[9.5] fix(servicenow): add compact role-based DLS to reduce ACL memory (#4392) - #4461
Merged
Merged
Conversation
## Closes elastic/chat-program#49 Part of elastic/chat-program#47. ServiceNow DLS expands every table read role into individual `user_id:` / `user:` / `email:` entries on each content document (and attachment). For large tenants — especially when a table ACL includes the `public` role — that can mean hundreds of thousands of ACL entries per document and OOM Elasticsearch during `_reindex`. This PR adds compact DLS, **opt-in** via `expand_role_members=false` (default `true` preserves existing behavior). When compact mode is enabled: - Content documents store compact `role_id:<sys_id>` tokens instead of every role member - Identity docs include role memberships from `sys_user_has_role` so DLS term overlap still works - Tables with a `public` read role omit `_allow_access_control` (world-readable via existing DLS `must_not exists`) - Tables where read roles cannot be resolved omit `_allow_access_control` (same as public tables; world-readable via existing DLS `must_not exists`) Also fixes advanced sync rules to resolve ACL per table instead of stamping an empty ACL on every batch. Changing the setting requires a full content sync and access control sync. ## Checklists #### Pre-Review Checklist - [x] this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check `config.yml.example`) - [x] this PR has a meaningful title - [x] this PR links to all relevant github issues that it fixes or partially addresses - [x] if there is no GH issue, please create it. Each PR should have a link to an issue - [x] this PR has a thorough description - [x] Covered the changes with automated tests - [x] Tested the changes locally - [ ] Added a label for each target release version (example: `v7.13.2`, `v7.14.0`, `v8.0.0`) - [ ] For bugfixes: backport safely to all minor branches still receiving patch releases - [ ] Considered corresponding documentation changes - [ ] Contributed any configuration settings changes to the configuration reference - [ ] if you added or changed Rich Configurable Fields for a Native Connector, you made a corresponding PR in [Kibana](https://github.com/elastic/kibana/blob/main/packages/kbn-search-connectors/types/native_connectors.ts) #### Changes Requiring Extra Attention - [x] Security-related changes (encryption, TLS, SSRF, etc) - [ ] New external service dependencies added. ## Related Pull Requests * #4396 — SharePoint Online compact site-group DLS (same tracking issue) * Kibana `native_connectors.ts` RCF for `expand_role_members` — to be opened separately ## Release Note ServiceNow document-level security can store compact role tokens on content documents instead of expanding every role member onto each record, reducing memory use for large tenants. Disable **Expand role members** to enable compact mode. The default preserves the previous per-user expansion behavior. Changing the setting requires a full content sync and access control sync. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
entsearchmachine
approved these changes
Sep 7, 2026
8 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 9.5: