feat: add ManagedCluster to the managed resources - #83
Open
FlorentClarret wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks for this. I need to look into this a bit more. Primary issue being is this the right resource name or should it be |
Author
I wast tempted to use |
Owner
|
@FlorentClarret apologies for the major delay! Can we rename it all to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #82
I'm not sure if there are some unit tests I can add, let me know if that's the case.
I tested it with my Azure account (I removed some of the info):
It took 4 minutes 11 here.
Side note: I wanted to map
g.SystemData.CreatedAtto the struct but it appears to be nil on my test