Skip to content

feat: add ManagedCluster to the managed resources - #83

Open
FlorentClarret wants to merge 2 commits into
ekristen:mainfrom
FlorentClarret:nuke-aks
Open

feat: add ManagedCluster to the managed resources#83
FlorentClarret wants to merge 2 commits into
ekristen:mainfrom
FlorentClarret:nuke-aks

Conversation

@FlorentClarret

@FlorentClarret FlorentClarret commented Aug 4, 2024

Copy link
Copy Markdown

Closes #82

I'm not sure if there are some unit tests I can add, let me know if that's the case.

I tested it with my Azure account (I removed some of the info):

../azure-nuke/bin/azure-nuke run --config clean.yaml --force --prompt-delay 3 --no-dry-run
> azure-nuke - 1.0.0-dev - dirty
Do you really want to nuke the tenant and subscriptions with the ID SUBSCRIPTION_ID?
Waiting 3s before continuing.
westus2 - ManagedCluster - testnuke - [ID: "", Name: "testnuke", Region: "westus2", ResourceGroup: "group", SubscriptionID: "SUBSCRIPTION_ID", tag:XXXX] - would remove
Scan complete: 1 total, 1 nukeable, 0 filtered.

Do you really want to nuke the tenant and subscriptions with the ID SUBSCRIPTION_ID?
Waiting 3s before continuing.
westus2 - ManagedCluster - testnuke - [ID: "", Name: "testnuke", Region: "westus2", ResourceGroup: "group", SubscriptionID: "SUBSCRIPTION_ID", tag:XXXX] - triggered remove

Removal requested: 1 waiting, 0 failed, 0 skipped, 0 finished

westus2 - ManagedCluster - testnuke - [ID: "", Name: "testnuke", Region: "westus2", ResourceGroup: "group", SubscriptionID: "SUBSCRIPTION_ID", tag:XXXX] - waiting

...

westus2 - ManagedCluster - testnuke - [ID: "", Name: "testnuke", Region: "westus2", ResourceGroup: "group", SubscriptionID: "SUBSCRIPTION_ID", tag:XXXX] - removed

Removal requested: 0 waiting, 0 failed, 0 skipped, 1 finished

Nuke complete: 0 failed, 0 skipped, 1 finished.

It took 4 minutes 11 here.

Side note: I wanted to map g.SystemData.CreatedAt to the struct but it appears to be nil on my test

@FlorentClarret FlorentClarret changed the title Add ManagedCluster to the managed resources feat: add ManagedCluster to the managed resources Aug 4, 2024
@ekristen

ekristen commented Aug 6, 2024

Copy link
Copy Markdown
Owner

Thanks for this. I need to look into this a bit more. Primary issue being is this the right resource name or should it be AKSCluster as generally folks know it as AKS.

@FlorentClarret

Copy link
Copy Markdown
Author

Thanks for this. I need to look into this a bit more. Primary issue being is this the right resource name or should it be AKSCluster as generally folks know it as AKS.

I wast tempted to use AKSCluster as it's also how I usually call it but I went with ManagedCluster because that's what we have in their SDK. AKSCluster might be more userfriendly

@ekristen

ekristen commented Dec 3, 2024

Copy link
Copy Markdown
Owner

@FlorentClarret apologies for the major delay! Can we rename it all to KubernetesCluster and we'll get it merged right in. Or I can modify your PR, up to you. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ManagedCluster to the list of managed resources

2 participants