fix(template): render stack section from caller-supplied order - #510
Open
davinkevin wants to merge 1 commit into
Open
fix(template): render stack section from caller-supplied order#510davinkevin wants to merge 1 commit into
davinkevin wants to merge 1 commit into
Conversation
The PR body's stack list was generated from info.PullRequests, which holds whatever insertion order spr.UpdatePullRequests produced — after a reorder + new commits are appended, the pre-existing top PR ends up at index 0 and is rendered at the bottom of every body's stack section. PRTemplatizer.Body now takes an explicit stack []*github.PullRequest. UpdatePullRequest forwards its already-sorted pullRequests parameter; CreatePullRequest forwards info.PullRequests as before. Regression test in template_stack feeds a misordered info and a correctly-ordered stack, and asserts the rendered markdown follows the stack arg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR body's stack list was generated from info.PullRequests, which holds whatever insertion order spr.UpdatePullRequests produced — after a reorder + new commits are appended, the pre-existing top PR ends up at index 0 and is rendered at the bottom of every body's stack section.
PRTemplatizer.Body now takes an explicit stack []*github.PullRequest. UpdatePullRequest forwards its already-sorted pullRequests parameter; CreatePullRequest forwards info.PullRequests as before.
Regression test in template_stack feeds a misordered info and a correctly-ordered stack, and asserts the rendered markdown follows the stack arg.