Use NuGet to reference ResourceLib and use the latest version - #10
Open
samhocevar wants to merge 1 commit into
Open
Use NuGet to reference ResourceLib and use the latest version#10samhocevar wants to merge 1 commit into
samhocevar wants to merge 1 commit into
Conversation
Collaborator
|
Thanks. I'll try to get this merged and do a release when I have access to a windows machine again, I don't have one right now :) |
|
@einaregilsson I also find this library useful. If you're interested in having it maintained while you don't have a Windows machine, I'm happy to help. |
Collaborator
|
@robdplatt Thanks, but I'll get it sorted next week, and do a release then :) No problem with the new version, no crashes or anything like that? |
|
@einaregilsson Works just the same with the updated ResourceLib. I did update a fork to .NET 4.7.2 for my projects. |
|
Will this work for programs built with .NET 6 without removing it's assembly metadata? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I have been successfully using InsertIcons for WinCompose for years but I have always had random crashes happening, and with recent changes in the Microsoft SDKs it just stopped working. While checking ResourceLib I noticed they had made a lot of bugfixes since 2012, including an off-by-one issue with multiple icon insertion, and one for compatibility with WPF applications.
This PR switches the ResourceLib dependency to NuGet so that it is trivial to upgrade to the latest version. Hope you find this useful.