Skip to content

feat: Remove CommonJS build#279

Merged
trygve-lie merged 5 commits into
mainfrom
no-commonjs
Jun 3, 2026
Merged

feat: Remove CommonJS build#279
trygve-lie merged 5 commits into
mainfrom
no-commonjs

Conversation

@trygve-lie

@trygve-lie trygve-lie commented May 29, 2026

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: This remove the support for CommonJS by removing the exported require export and the internal build step which builds a CommonJS version. This should not matter much due to the fact that newer versions of node.js now have support for both ESM and CommonJS co-existing.

BREAKING CHANGE

This remove the support for CommonJS by removing the exported require export and the internal build step which builds a CommonJS version.
This should not matter much due to the fact that newer versions of node.js now have support for both ESM and CommonJS co-existing.
@wkillerud

Copy link
Copy Markdown
Contributor

I think the syntax for semantic release is a bit off, it should be

feat: Remove CommonJS build

BREAKING CHANGE: This remove the support for CommonJS by removing the
exported require export and the internal build step which builds a
CommonJS version. This should not matter much due to the fact that
newer versions of node.js now have support for both ESM and CommonJS
co-existing.

or

feat!: Remove CommonJS build

This remove the support for CommonJS by removing the exported require
export and the internal build step which builds a CommonJS version.
This should not matter much due to the fact that newer versions of
node.js now have support for both ESM and CommonJS co-existing.

@wkillerud

wkillerud commented May 29, 2026

Copy link
Copy Markdown
Contributor

LGTM other than the commit message for semrel, can do that as part of a squash 👍

Base automatically changed from replace-tap to main May 29, 2026 13:38
BREAKING CHANGE: This remove the support for CommonJS by removing the
exported require export and the internal build step which builds a
CommonJS version. This should not matter much due to the fact that
newer versions of node.js now have support for both ESM and CommonJS
co-existing.
@trygve-lie trygve-lie merged commit 8d0d75b into main Jun 3, 2026
6 checks passed
@trygve-lie trygve-lie deleted the no-commonjs branch June 3, 2026 13:26
github-actions Bot pushed a commit that referenced this pull request Jun 3, 2026
# [2.1.0](v2.0.27...v2.1.0) (2026-06-03)

### Features

* Remove CommonJS build ([#279](#279)) ([8d0d75b](8d0d75b))
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants