4.x: apply formatState() in text-column view; allow illuminate ^13 - #64
Open
byjujohn wants to merge 3 commits into
Open
4.x: apply formatState() in text-column view; allow illuminate ^13#64byjujohn wants to merge 3 commits into
byjujohn wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AYdjTQC47Yzs6R1a5iCVaJ
…/date were ignored The v4 rewrite renders $getState() raw, so every column formatter (formatStateUsing, money(), date(), numeric()) is silently skipped. CanFormatState::formatState() already implements the full pipeline; the view just never called it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AYdjTQC47Yzs6R1a5iCVaJ
…nCenter() only affected headers The body table blade computes alignment classes for head and summary cells but never for data cells, so alignRight() etc. render left-aligned data. Reuses the identical class mapping on the grouped and normal cell variants. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AYdjTQC47Yzs6R1a5iCVaJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from running 4.x-dev in a production-shaped app (29 report classes, 1,800+ tests) on Filament 4/5 and Laravel 12/13:
Column formatting is silently ignored.
components/body/text-column.blade.phprenders$getState()raw, soformatStateUsing(),money(),date()andnumeric()never run — amounts render as bare floats.CanFormatState::formatState()already implements the whole pipeline (incl. HTML sanitisation and HtmlString passthrough); the view just never called it. One-line fix:$state = $formatState($getState());Laravel 13:
illuminate/contractswidened to include^13.0— no code changes were needed under Laravel 13 in our testing.🤖 Generated with Claude Code
https://claude.ai/code/session_01AYdjTQC47Yzs6R1a5iCVaJ