feat(asb): profiling#1130
Open
binarybaron wants to merge 1 commit into
Open
Conversation
Serve jemalloc heap and pprof CPU profiles from the ASB metrics server at
/debug/pprof/{heap,profile} behind a network.profiling flag, with an opt-in
orchestrator Alloy agent that scrapes them into Grafana Pyroscope.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e2ab80c. Configure here.
| build_alloy_config(pyroscope, recipe.ports.asb_metrics_port), | ||
| ) | ||
| .expect("Failed to write alloy.alloy"); | ||
| } |
There was a problem hiding this comment.
Pyroscope skips config patch
Medium Severity
Enabling Pyroscope via the orchestrator writes alloy.alloy and compose changes but does not update an existing ASB config.toml with network.profiling or prometheus_port. The metrics HTTP server stays off or serves without pprof routes, so Alloy scrapes fail while profiling appears enabled.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e2ab80c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.