feat(state machine, alice): separate xmr lock constructed state#1126
Merged
Einliterflasche merged 2 commits intoJun 19, 2026
Conversation
|
likely cause of bug for unpublished transactions not rebroadcasting and stuck at 0/10 |
Author
|
Proper fix for this is being worked on in #1142 |
Yes but this was still required as a safety precaution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New state XmrLockTransactionConstructed. No functional difference, but improved atomicity. New state is handled very conservatively: mostly like XmrLocked except we count the Monero for this swap as still being reserved.
No scanning the swap wallet yet, the tx is imported into the monero-sys wallet immediately after publishing.