Fix macOS CI by installing gcc for gfortran - #42
Merged
Conversation
The macOS setup step only prepended $(brew --prefix gcc)/bin to PATH without installing the formula. brew --prefix exits 0 for any known formula whether or not it is installed, so the step passed while adding a non-existent directory, and meson then failed with "Unknown compiler(s)" when detecting Fortran. Install gcc (which provides gfortran) and verify it, so a missing toolchain fails loudly at setup instead of inside meson. Applied to build.yml, test.yml and release-pypi.yml -- the last of which would otherwise publish a release with no macOS wheels. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
macos-latest has rolled to macOS 26, so Homebrew serves gcc bottles whose libgfortran, libquadmath and libgcc_s carry minos 26.0. delocate vendors those into the wheel and then rejects them against MACOSX_DEPLOYMENT_TARGET=15.0, since the result would install on macOS 15 and fail at import. Pin the runner to macos-15 so the bottles match the wheel target. The image and MACOSX_DEPLOYMENT_TARGET must now be kept in sync. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
test_banana_no_constraints called pso() with no seed while asserting convergence to within atol=0.001. PSO is stochastic, so the assertion fails on roughly 1.3% of runs (measured over 300 unseeded runs; worst deviation 1.77e-02, 17x the tolerance). Across a 15-job matrix that is about a 1-in-5 chance of a red run with nothing actually broken. Pin seed=2, which converges to within 1.4e-06 -- a 707x margin under the tolerance, so platform floating-point differences cannot cross it. Seed the constrained variant likewise; every other test in the suite already pins a seed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS setup step only prepended $(brew --prefix gcc)/bin to PATH without installing the formula. brew --prefix exits 0 for any known formula whether or not it is installed, so the step passed while adding a non-existent directory, and meson then failed with "Unknown compiler(s)" when detecting Fortran.
Install gcc (which provides gfortran) and verify it, so a missing toolchain fails loudly at setup instead of inside meson.
Applied to build.yml, test.yml and release-pypi.yml -- the last of which would otherwise publish a release with no macOS wheels.