Skip to content

added BidirectionalScrollViewPlugin #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
efortuna wants to merge 3 commits into
base: main
Choose a base branch
from
Open

added BidirectionalScrollViewPlugin #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ff644d
added BidirectionalScrollViewPlugin
efortuna Feb 14, 2022
e098c20
updated readme
efortuna Feb 14, 2022
35c5085
hello
efortuna Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@ Also known as "Dude, where's my pull request?"
Instructions for running:

- Make sure your computer is set up to run [Flutter code](https://flutter.io/)
- Check out repository...
- Check out repository.
- Create a token.dart file in lib/full_version/github/. This file needs to contain a variable defining your [github access token](https://help.github.com/articles/creating-a-personal-access-token-for-the-command-line/). The file should look something like this:

const token = 'my personal Github token here';

- ...Profit??
- Watch out for BidirectionalScrollViewPlugin hello world

@semgrep-app semgrep-app Bot Feb 14, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Hello World' is disallowed in this codebase.

Click here if this comment is not useful

Please address this comment before merging this pull request.
(untitled_rule in Rule board)

9 changes: 8 additions & 1 deletion lib/presentation/review_code.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,14 @@ class ReviewPage extends StatelessWidget {

@override
Widget build(BuildContext context) {
return Scaffold(appBar: AppBar(title: Text('Review Pull Request')));
return Scaffold(
appBar: AppBar(title: Text('Review Pull Request')),
body: BidirectionalScrollViewPlugin(
child: Padding(
padding: const EdgeInsets.all(10.0),
child: styledCode(prDiff),
),
));
}

RichText styledCode(String prDiff) {
Expand Down