Repository navigation
Conversation
Adds the species record, a species-local swim/dive and flight behaviour programme (fsm-bufflehead-diver-v1), regenerated attribution and the US activity curve from fetch_activity. Refs #631 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
- Remove the invented US-wide absent phase (June-September), which contradicted ADW's isolated northern US breeding populations and was not a sourced window. Keep CA and US-AK breeding phases only. - Strategy is ActiveYearRound as a placeholder: the schema requires an 'absent' phase for Migration, and no consulted licensed source gives a defensible region-scoped absence. Migration is not modelled (see PR). - Describe the activity curve as an observation-frequency proxy; the iNaturalist histogram total is capped at 10000 by the API. - Behaviour: state that dives are not depicted (eat_nearest with gait swim, no submerged pose). Feeding starts only in daylight; a feeding bird roosts on water after dark; night rest is sun-elevation gated. - Poses: fly amplitude 1.3; swim paddle keyframes; rest head tuck. - ADW: re-checked lifespan figures and use conditions (CC BY-NC-SA 3.0); corrected the citation. Narrowed NC coverage to the datums that need it. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
6 tasks
Collaborator
Author
|
Coordinator review: the record explicitly uses ActiveYearRound as a placeholder for a migratory species because the required regional absence window is unresolved. The preview also reports an unrepresentative swim pose. This leaves seasonal behavior and pose review unfinished, so it does not meet the strict near-complete draft rule in AGENTS.md. Preserving pushed branch wave-20261101d-631-bucephala-albeola and the sourced evidence on issue #631; no merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #631. Supersedes the closed draft #1310, which was closed without merge.
What changed since #1310
ActiveYearRoundas a placeholder. This is the open gap (see below). The schema requires anabsentphase forMigration. No consulted licensed source gives a defensible region-scoped absence window, so migration is not modelled.fetch_activity.pyreproduced the stored counts.eat_nearestwith gaitswimmoves the bird below the surface in the simulation, but the model has no submerged pose. Feeding starts only in daylight. A feeding bird roosts on water after dark (sun elevation between -90 and -6). ADW says winter birds forage at night, and this program does not model that.Missing value (1 factual gap)
seasonal.strategy/ seasonal absence. The species migrates: it breeds in Alaska and Canada and winters on the US coasts, the southern US and the Great Lakes (Wikipedia; ADW). A licensed, region-scoped absence window for the breeding populations is needed to useMigration. Checked: Wikipedia (lead, Description, Breeding, Diet, raw wikitext of the current revision) and ADW (Geographic Range, Breeding, Lifespan, Behavior). Neither gives a dated absence for CA or US-AK, and ADW reports breeding in the northern United States. The fix needs a licensed source for the absence window, or a decision to accept ActiveYearRound.Validation (commit 397288e)
uv run tools/validate.py species/bucephala-albeola --write-attribution --report: 0 errors, 1 warning (NonCommercialLicense, ADW CC BY-NC-SA 3.0, last resort). Provenance 34/34. Attribution regenerated;git diff -- speciesempty afterwards.uv run tools/validate.py --self-check: 629 files, 0 findings.uv run tools/validate.py --report: 192 species, 0 errors.uv run tools/validate.py --locale all --report: 33 locales, all pass.uv run --with pytest --with jsonschema pytest tools/tests -q: 347 passed, 8 skipped.Preview (inspected)
Previewer at 127.0.0.1 on the built site, pose screenshots in headless Chromium (no console errors). Inspected: idle, swim, fly, rest.
biped_wingedrenderer has noswimbranch, so swim falls through to the walk/hop cycle. The paddle keyframes give a modest leg difference, and there is no waterline or submerged body. This is a shared renderer issue that also affects the five otherbiped_wingedspecies with a swim pose. It is not fixed here.Not checked
ActiveYearRoundfor a migrant (birds may stay present in winter in the breeding regions) cannot be observed from this repository.Closes nothing: Refs #631.
🤖 Generated with Claude Code