feat: Upgrade Button plugin import in learner dash - #25
Merged
Conversation
mshet-sonata-pixel
changed the title
mshet-sonata-pixel
changed the title
mshet-sonata-pixel
changed the title
MaxFrank13
reviewed
Jul 30, 2026
| "tsc-alias": "^1.8.16", | ||
| "turbo": "^2.8.20" | ||
| "turbo": "^2.8.20", | ||
| "@edx/react-unit-test-utils": "^4.0.0" |
Member
There was a problem hiding this comment.
This package installs a version of frontend-platform as a dependency. So we end up with both frontend-base and frontend-platform in the package-lock.json file. We'll need to find a way to write the UpgradeButtonWrapper.test.jsx tests without the @edx/react-unit-test-utils package. This most likely means abandoning snapshot based testing and using @testing-library/react like we do for most of our other unit tests.
For context: the snapshot pattern with @edx/react-unit-test-utils is outdated. The repository has been archived as of October 2nd, 2025. So the package doesn't have future support (or current support technically as it requires frontend-platform).
MaxFrank13
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket - https://2u-internal.atlassian.net/browse/SUBS-801
Here the Upgrade Button plugin migrated from frontend-plugin-learner-dashboard into learner dashboard.
To Test:
Clone the Repo,
Be in this branch
Be in learner-dashboard url
you see the upgrade button at course card action slot