MEI-15697 Staff tools - download failure - #2168
Conversation
| csvwriter = csv.writer(output_buffer) | ||
| csvwriter.writerows(self._get_utf8_encoded_rows(rows)) | ||
| csvwriter.writerows(self._get_utf8_encoded_rows(rows, encode_for_utf8=True)) | ||
| output_buffer.seek(0) | ||
| self.store(course_id, filename, output_buffer) | ||
| self.store(course_id, filename, output_buffer, batched=True) | ||
|
|
There was a problem hiding this comment.
The store_rows usage of the instructor_task app is widespread as it's being used in different xblocks as well as edx itself. So It's good to do the change where it's impacting and use add_rows and call store method rather than changing in a core function.
There was a problem hiding this comment.
@mudassir-hafeez
I have updated the Pull Request and used default arguments in store_rows so that the widespread usage of this method doesn't get affected.
|
@mudassir-hafeez , |
|
Build is being failed due to xblock poll repo. wasn't that fixed by token used by you previously? |
|
@mudassir-hafeez I haven't merged personal access token on QA because it was finalised yet at that time by DevOps |
2 participants
No description provided.