feat: Android - Implementation of Picture in Picture for the youtube pl… by dsandeepkumar2830 · Pull Request #217 · edx/edx-mobile-marketplace-android

dsandeepkumar2830 · 2026-05-14T06:47:54Z

Android - Implementation of Picture in Picture for the exo player and youtube video player

…ayer with media playback controls

…tes.

…uplicates." This reverts commit f29341f.

This reverts commit b3319e2.

This reverts commit f29341f

…tes.

…uplicates." This reverts commit f29341f.

This reverts commit b3319e2.

kalalmounesh · 2026-07-15T07:21:23Z

Remove this class i didn't find any usage.i found 4 files remove all

If we remove this run test is failed.

@kalalmounesh you can check the screenshots in 2u/develop branch already there are 3 json files , and if you remove these json files run tests will be failing in PR.

and Kindly refer this document
json

kalalmounesh · 2026-07-15T07:23:49Z

+            }
+        })
+
+


Remove this extra lines.

This is fixed.

kalalmounesh · 2026-07-15T07:26:53Z

Remove this class i didn't find any usage.

This is fixed

kalalmounesh · 2026-07-15T07:29:02Z

Regarding the documents remove all and add one or max two valid doc in confluence.

This is fixed

kalalmounesh · 2026-07-15T07:31:23Z

+        }
+
+    }
+


Remove this extra lines

This is fixed

kalalmounesh · 2026-07-15T08:38:02Z


+    private val constraintContainer: ConstraintLayout
+        get() = binding.rootLayout as ConstraintLayout
+


Remove this extra lines.

This is fixed

maheshchathani · 2026-07-16T06:55:53Z


    viewModel { (courseId: String?, infoType: String?) ->
-        WhatsNewViewModel(
+        WhatsNewViewModel(  


There are a few extra spaces and empty lines added here. Please remove them to keep the formatting clean and consistent.

This is fixed

maheshchathani · 2026-07-16T06:56:35Z

+ * Repository for managing PiP player state.
+ *
+ * Single source of truth for:
+ * - Which player is currently registered for PiP


I don't think we need to add comments/docstrings for every function and class in these newly added PIP-related files. We don't follow this pattern in the existing codebase, so it would be better to keep it consistent.

This is fixed

maheshchathani · 2026-07-16T06:57:47Z

I don't think these documentation files (Architecture Review, Changes, and Fixes) are required. We don't have similar documentation files elsewhere in the project, so it would be better to keep the repository consistent.

This is fixed

maheshchathani

Review completed.

I have a few suggestions:

Please remove the extra spaces and unnecessary empty lines that were added.
For the newly added PIP-related files, I don't think we need comments/docstrings for every function and class. We don't usually add them throughout the existing codebase, so it would be better to keep it consistent.
I also don't think we need to add the PIP documentation files (Architecture Review, Changes, and Fixes). There are no similar documentation files in the project so far, so I don't think these are required.

Other than these suggestions, the changes look good to me.

dsandeepkumar2830 · 2026-07-17T06:11:01Z

Review completed.

I have a few suggestions:

Please remove the extra spaces and unnecessary empty lines that were added.

For the newly added PIP-related files, I don't think we need comments/docstrings for every function and class. We don't usually add them throughout the existing codebase, so it would be better to keep it consistent.

I also don't think we need to add the PIP documentation files (Architecture Review, Changes, and Fixes). There are no similar documentation files in the project so far, so I don't think these are required.

Other than these suggestions, the changes look good to me.

dsandeepkumar2830 · 2026-07-17T06:12:26Z

@kalalmounesh @maheshchathani I have fixed the review comments and regarding the .md files I have removed the most of the files. Please review and approve and let me know if any changes need to be fixed.

kalalmounesh

We are able to see some code related to crash fix in CL 461de61, impact of the changes should be validated by QA.
Rest of the fixes are good to go.

roy-sumanta

Approved, based on the changes done.

dsandeepkumar2830 added 30 commits March 30, 2026 13:04

feat: Android - Implementation of Picture in Picture for the video pl…

4610a69

…ayer with media playback controls

refactor: mapping file changes reverted

2083312

fix: Kept a single set of Media3 dependencies.

18c0a85

fix: Kept a single set of Media3 dependencies and removed the duplica…

52f5db6

…tes.

fix: Kept a single set of Media3 dependencies

9f133ad

Revert "fix: Kept a single set of Media3 dependencies & removed the d…

c7206b3

…uplicates." This reverts commit f29341f.

refactor: duplicate Media3 dependencies and align versions"

c6953cf

refactor: Copilot changes removed duplicate Media3 dependencies

b1290b7

Revert "refactor: Copilot changes removed duplicate Media3 dependencies"

83ad9aa

This reverts commit b3319e2.

Revert "refactor: Kept a single set of Media3 dependencies"

d64b4ca

This reverts commit f29341f

refactor: kept a single set of Media3 dependencies.

f28e67a

fix: Kept a single set of Media3 dependencies and removed the duplica…

4dc19b1

…tes.

fix: Kept a single set of Media3 dependencies

f4ebf6b

Revert "fix: Kept a single set of Media3 dependencies & removed the d…

a33a907

…uplicates." This reverts commit f29341f.

refactor: duplicate Media3 dependencies and align versions"

625efa4

refactor: Copilot changes removed duplicate Media3 dependencies

faf9511

Revert "refactor: Copilot changes removed duplicate Media3 dependencies"

616de33

This reverts commit b3319e2.

refactor: Copilot changes resolved in dimen file

2874d7e

refactor: Copilot changes resolved

fdca26d

refactor: Copilot changes resolved with suggested changes

b9fec68

refactor: review changes resolved

536d984

feat: Implemented pip for youtube video player

4e355ef

feat: Implemented pip youtube video player controls

5f7134e

refactor: Copilot review changes fixed

df8982e

refactor: Removed config chanegs as copilot suggested

ca8a753

refactor: Added space

cd263e3

refactor: Copilot code review changes fixed

f96c71c

refactor: Copilot code review changes fixed

e7e033f

fix: Architecture and DI changes

c6e6c73

fix: BroadcastReceiver class changes

b7e5d52

dsandeepkumar2830 added 7 commits May 15, 2026 14:05

refactor: reverted config file

e48f1f2

refactor: overlap issues fixed in Exo & Youtube

44cd06d

refactor: copilot fixes and Arch & DI fixes

6d6d548

refactor: moved pip fixes md files into Documentation

309f116

fix: pip fixes

fe13067

refactor: Code cleanup

b273b20

fix: Exo player multi video player isssue in PIP

dea9fcd

kalalmounesh reviewed Jul 15, 2026

View reviewed changes

maheshchathani reviewed Jul 16, 2026

View reviewed changes

dsandeepkumar2830 added 4 commits July 16, 2026 18:07

fix: Pip code review fixes

7ae6aa3

fix: Crash issue in build

461de61

fix: Removed extra lines

a745d15

fix: Removed extra lines in YoutubeVideoUnitFragment.kt

4eca9e7

maheshchathani approved these changes Jul 17, 2026

View reviewed changes

dsandeepkumar2830 added 4 commits July 17, 2026 12:02

fix: Removed .json files

937c9d3

fix: Removed SharedViewModel and added in PipViewModel

80392cd

fix: Test file fixed

32898d9

fix: Reverted json files

bacaf3b

kalalmounesh approved these changes Jul 17, 2026

View reviewed changes

roy-sumanta approved these changes Jul 17, 2026

View reviewed changes


		private val constraintContainer: ConstraintLayout
		get() = binding.rootLayout as ConstraintLayout

Uh oh!

Conversation

dsandeepkumar2830 commented May 14, 2026

Uh oh!

kalalmounesh Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsandeepkumar2830 Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsandeepkumar2830 Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsandeepkumar2830 Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kalalmounesh Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maheshchathani left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsandeepkumar2830 commented Jul 17, 2026

Uh oh!

dsandeepkumar2830 commented Jul 17, 2026

Uh oh!

kalalmounesh left a comment

Choose a reason for hiding this comment

Uh oh!

roy-sumanta left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kalalmounesh Jul 15, 2026 •

edited

Loading

dsandeepkumar2830 Jul 17, 2026 •

edited

Loading

dsandeepkumar2830 Jul 17, 2026 •

edited

Loading

dsandeepkumar2830 Jul 17, 2026 •

edited

Loading

kalalmounesh Jul 15, 2026 •

edited

Loading

maheshchathani left a comment •

edited

Loading