Skip to content

Amend the virtualenv path in pyvenv.cfg command - #84

Open
hroncok wants to merge 1 commit into
edwardgeorge:masterfrom
hroncok:virtualenv-20.38
Open

Amend the virtualenv path in pyvenv.cfg command#84
hroncok wants to merge 1 commit into
edwardgeorge:masterfrom
hroncok:virtualenv-20.38

Conversation

@hroncok

@hroncok hroncok commented Mar 6, 2026

Copy link
Copy Markdown

pypa/virtualenv@44b7bd6

Without this, test_clone_contents fails with virtualenv 20.38.0+:

                with open(file_in_clone, 'rb') as f:
                    lines = f.read().decode('utf-8')
>                   assert venv_path not in lines,\
                        'Found source path in cloned file %s' % file_in_clone
E                   AssertionError: Found source path in cloned file /tmp/tmp_lsp66c7/clone_venv/pyvenv.cfg
E                   assert '/tmp/tmp_lsp66c7/srs_venv' not in 'home = /usr/bin\nimplementation = CPython\nversion_info = 3.14.3.final.0\nversion = 3.14.3\nexecutable = /usr/bin/python3.14\ncommand = /.../virtualenv-clone/.tox/py314/bin/python3 -m virtualenv /tmp/tmp_lsp66c7/srs_venv\nvirtualenv = 21.1.0\ninclude-system-site-packages = false\nbase-prefix = /usr\nbase-exec-prefix = /usr\nbase-executable = /usr/bin/python3.14\n'
E
E                     '/tmp/tmp_lsp66c7/srs_venv' is contained here:
E                       home = /usr/bin
E                       implementation = CPython
E                       version_info = 3.14.3.final.0
E                       version = 3.14.3
E                       executable = /usr/bin/python3.14
E                       command = /.../virtualenv-clone/.tox/py314/bin/python3 -m virtualenv /tmp/tmp_lsp66c7/srs_venv
E                     ?                                                                                                   +++++++++++++++++++++++++
E                       virtualenv = 21.1.0
E                       include-system-site-packages = false
E                       base-prefix = /usr
E                       base-exec-prefix = /usr
E                       base-executable = /usr/bin/python3.14

Fixes #83

pypa/virtualenv@44b7bd6

Without this, test_clone_contents fails with virtualenv 20.38.0+:

                    with open(file_in_clone, 'rb') as f:
                        lines = f.read().decode('utf-8')
    >                   assert venv_path not in lines,\
                            'Found source path in cloned file %s' % file_in_clone
    E                   AssertionError: Found source path in cloned file /tmp/tmp_lsp66c7/clone_venv/pyvenv.cfg
    E                   assert '/tmp/tmp_lsp66c7/srs_venv' not in 'home = /usr/bin\nimplementation = CPython\nversion_info = 3.14.3.final.0\nversion = 3.14.3\nexecutable = /usr/bin/python3.14\ncommand = /.../virtualenv-clone/.tox/py314/bin/python3 -m virtualenv /tmp/tmp_lsp66c7/srs_venv\nvirtualenv = 21.1.0\ninclude-system-site-packages = false\nbase-prefix = /usr\nbase-exec-prefix = /usr\nbase-executable = /usr/bin/python3.14\n'
    E
    E                     '/tmp/tmp_lsp66c7/srs_venv' is contained here:
    E                       home = /usr/bin
    E                       implementation = CPython
    E                       version_info = 3.14.3.final.0
    E                       version = 3.14.3
    E                       executable = /usr/bin/python3.14
    E                       command = /.../virtualenv-clone/.tox/py314/bin/python3 -m virtualenv /tmp/tmp_lsp66c7/srs_venv
    E                     ?                                                                                                   +++++++++++++++++++++++++
    E                       virtualenv = 21.1.0
    E                       include-system-site-packages = false
    E                       base-prefix = /usr
    E                       base-exec-prefix = /usr
    E                       base-executable = /usr/bin/python3.14

Fixes edwardgeorge#83
jerome-benoit added a commit to jerome-benoit/dotfiles that referenced this pull request Jul 11, 2026
- forceLld helper: force -fuse-ld=lld to dodge the cctools ld64 hardening
  SIGTRAP (exit 133) at link on darwin, applied to qtkeychain (qt6 scope),
  whisper-cpp, rectangle, and nheko (nheko also rewired onto the fixed
  qt6Packages via override). See NixOS/nixpkgs#540054.
- virtualenv-clone: apply upstream fix-pyvenv-cfg-path patch
  (edwardgeorge/virtualenv-clone#84) - test_clone_contents breaks on
  virtualenv 21.x/py3.14.
- opentelemetry-exporter-otlp-proto-grpc: disable wall-clock timing tests
  (retry/timeout) flaky in the build sandbox.
- Drop obsolete a2a-sdk test override (fixed upstream, builds from cache).
jerome-benoit added a commit to jerome-benoit/dotfiles that referenced this pull request Jul 12, 2026
…table

The channel advanced to include the upstream fix-pyvenv-cfg-path patch
(edwardgeorge/virtualenv-clone#84), so the local overlay + patch would
double-apply. Remaining darwin overlays (forceLld, crush, opentelemetry)
stay: their fixes aren't upstream yet (ld64 hardening revert #536365 open).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure with virtualenv 20.38.0+

1 participant