Skip to content

Fix Electrum v1 seed/key derivation and unify NFKD normalization #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 14 commits into
base: 0.1.5-dev-electrum-seed
Choose a base branch
from
Draft

Fix Electrum v1 seed/key derivation and unify NFKD normalization #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
bc8b234
bip39, such, test: add electrum seed support
edtubbs Feb 4, 2026
de99bd9
Initial plan
Copilot Feb 16, 2026
e706b46
Fix Electrum v1 seed derivation, key derivation, and update tests
Copilot Feb 16, 2026
fe42755
Move stretching from seed function to key derivation
Copilot Feb 17, 2026
fd65c17
Use uncompressed keys for Electrum v1 per bip-utils reference
Copilot Feb 17, 2026
791da11
Zero-initialize wif_payload buffer before use
Copilot Feb 17, 2026
d3ec0c9
Add bip-utils bounce test for 'like just love...' mnemonic
Copilot Feb 17, 2026
b7abcda
Replace strtok with manual tokenizer for OP-TEE compatibility
Copilot Feb 17, 2026
cb2ceca
Use strtok_r instead of manual tokenizer in electrum_v1_decode_mnemonic
Copilot Feb 17, 2026
ace31de
Document v1 12-word requirement and ASCII/NFKD normalization equivalence
Copilot Feb 17, 2026
2107084
Plan: Fix return convention, use utf8proc_NFKD, remove test overlap
Copilot Feb 17, 2026
d347866
Remove duplicate electrum tests between key_tests and bip39_tests
Copilot Feb 17, 2026
6fcc93f
Use utf8proc_map NFKD+CASEFOLD instead of manual lowercase loops
Copilot Feb 17, 2026
76aef8c
Fix Windows CI linker error: define UTF8PROC_STATIC in bip39.c
Copilot Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,652 changes: 1,652 additions & 0 deletions include/bip39/electrum.h
View file
Open in desktop

Large diffs are not rendered by default.

20 changes: 20 additions & 0 deletions include/dogecoin/bip39.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,26 @@ LIBDOGECOIN_API int generateRandomEnglishMnemonic(const ENTROPY_SIZE size, MNEMO
/* return: 0 (success), -1 (fail) */
LIBDOGECOIN_API int generateEnglishMnemonic(const HEX_ENTROPY entropy, const ENTROPY_SIZE size, MNEMONIC mnemonic);

/* Check if mnemonic is an Electrum v2+ seed */
/* mnemonic code words */
/* pointer to receive version number (optional, may be NULL) */
/* returns 0 (success), -1 (fail) */
LIBDOGECOIN_API int dogecoin_mnemonic_is_electrum_seed(const char* mnemonic, uint32_t* out_version);

/* Derive the seed from an Electrum v2+ mnemonic and optional passphrase */
/* mnemonic code words */
/* passphrase (optional) */
/* 512-bit seed */
/* returns 0 (success), -1 (fail) */
LIBDOGECOIN_API int dogecoin_seed_from_electrum_mnemonic(const char* mnemonic, const char* passphrase, SEED seed);

/* Derive the seed from an Electrum v1 mnemonic and optional passphrase */
/* mnemonic code words (12 words from 1626-word list) */
/* passphrase (optional) */
/* 512-bit seed (16 bytes of decoded entropy, zero-padded) */
/* returns 0 (success), -1 (fail) */
LIBDOGECOIN_API int dogecoin_seed_from_electrum_v1_mnemonic(const char* mnemonic, const char* passphrase, SEED seed);

LIBDOGECOIN_END_DECL

#endif // __LIBDOGECOIN_BIP39_H__
7 changes: 7 additions & 0 deletions include/dogecoin/key.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,13 @@ LIBDOGECOIN_API void getWifEncodedPrivKey(const uint8_t privkey[DOGECOIN_ECKEY_P
// wrapper for wif decoding
LIBDOGECOIN_API int getDecodedPrivKeyWif(const char privkey_wif[PRIVKEYWIFLEN], const dogecoin_bool is_testnet, uint8_t privkey[DOGECOIN_ECKEY_PKEY_LENGTH]);

// Electrum v1 (pre-v2) deterministic key derivation.
// Takes raw 16-byte v1 seed (in first 16 bytes), stretches it, and derives child key.
LIBDOGECOIN_API int electrum_v1_derive_privkey32(const uint8_t v1_seed[32],
uint32_t n,
uint32_t for_change,
uint8_t out_priv32[32]);

LIBDOGECOIN_END_DECL

#endif // __LIBDOGECOIN_KEY_H__
Loading
Loading