Conversation
Merge dev branch
Merge dev
There was a problem hiding this comment.
Pull request overview
This pull request adds Ghidra 12 support to the project by expanding the CI test matrix to include Ghidra version 12.0 alongside the existing 11.3.2 version. This ensures broader compatibility testing across multiple Ghidra versions.
Key changes:
- Extends the GitHub Actions test matrix to include Ghidra 12.0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Test against multiple Ubuntu versions and Ghidra versions for broader compatibility | ||
| os: [ubuntu-22.04, ubuntu-24.04] | ||
| ghidra_version: ["11.3.2"] | ||
| ghidra_version: ["11.3.2", "12.0"] |
There was a problem hiding this comment.
The version "12.0" appears to be incorrect. Ghidra 12's official release uses version "12.0.0", not "12.0". This will cause the workflow to fail when attempting to download Ghidra because:
- The GitHub release tag is "Ghidra_12.0.0_build" (not "Ghidra_12.0_build")
- The extracted directory name is "ghidra_12.0.0_PUBLIC" (not "ghidra_12.0_PUBLIC")
The version should be changed to "12.0.0" to match Ghidra's actual release naming convention.
| ghidra_version: ["11.3.2", "12.0"] | |
| ghidra_version: ["11.3.2", "12.0.0"] |
|
12.0 is failing because pyghidra is now the default. We should merge in #4 and then this will hopefully fix that. |
No description provided.