🧪 Improve process-mappings consumption testing - #172
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
🎯 What: The testing gap in
validate_consumptionerror branches was addressed. Added extensive negative testing permutations that test schema digest mismatch, schema path resolution, empty inputs, non-dictionary components, missing keys, and invalid property structures that were previously uncovered.📊 Coverage: Achieved 100% test coverage for
src/pic_contracts/process_mappings_consumption.py, up from ~64%. All logical branches are covered, validating robust failure mode behavior.✨ Result: Robust regression safety for local consumption tests on pinned external manifests. Ensures the library correctly rejects invalid schemas, bad formatting, escaped directory paths, and malformed contract parameters.
PR created automatically by Jules for task 2914775939374426167 started by @edithatogo