sealing: re-seal KEK if seal mode changes - #922
Merged
Conversation
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
daniel-weisse
added
the
bug fix
thomasten
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In the past we have seen intermittent failure of the image upgrade e2e tests.
After some investigation, I could narrow this down to being an issue with unsealing the KEK with new Coordinators on all nodes but the one where an old Coordinator instance originally received the manifest.
Turns out the seal mode of the KEK was never updated on "secondary" instances after the manifest gets set.
In cases where the test scheduled no new Coordinator instances on the node where the original manifest got set, no new instance can load a KEK, resulting in test failure.
Proposed changes
Additional info