Repository navigation
Conversation
Bump transitive @hono/node-server 1.19.14 -> 1.19.17 for GHSA-frvp-7c67-39w9 (serve-static path traversal on Windows). Lockfile-only: @modelcontextprotocol/sdk 1.30.0 already accepts ^1.19.9. Not reachable here; this package does not use serve-static. Split validateServerConfig, generateDockerfile and buildMatchmakerConfig into single-purpose helpers. Signatures, return shapes, messages and finding order are unchanged. Cyclomatic complexity (fallow 3.32.0): validateServerConfig 72 -> 6 generateDockerfile 28 -> 9 buildMatchmakerConfig 23 -> 12 No function in the three files now exceeds 12 cyclomatic or 11 cognitive.
Contributor
|
thanks for that. i missed the PR and added the update in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump transitive @hono/node-server 1.19.14 -> 1.19.17 for GHSA-frvp-7c67-39w9 (serve-static path traversal on Windows). Lockfile-only: @modelcontextprotocol/sdk 1.30.0 already accepts ^1.19.9. Not reachable here; this package does not use serve-static.
Split validateServerConfig, generateDockerfile and buildMatchmakerConfig into single-purpose helpers. Signatures, return shapes, messages and finding order are unchanged.
Cyclomatic complexity (fallow 3.32.0):
validateServerConfig 72 -> 6
generateDockerfile 28 -> 9
buildMatchmakerConfig 23 -> 12
No function in the three files now exceeds 12 cyclomatic or 11
cognitive.