chore: bump all deps#241
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the repo to newer dependency versions (notably Fastify and Fastify plugins), and adjusts the library/tests/examples to match changed behavior (e.g., cookie headers and SameSite defaults), while removing a now-unneeded polyfill.
Changes:
- Bump key dev dependencies (e.g.,
fastifyto v5,@fastify/cookieto v11) and regeneratepnpm-lock.yaml. - Remove the global polyfill import and delete the polyfill implementation.
- Update response/cookie-related tests and examples; tighten some typings (e.g.,
isBinarytype guard,SageHttpResponseconstructor typing).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
package.json |
Dependency bumps (Fastify + plugins) and adds packageManager pin. |
pnpm-lock.yaml |
Lockfile refresh reflecting dependency upgrades and new transitive deps/engines. |
src/index.ts |
Removes polyfill side-effect import. |
src/polyfill.ts |
Deletes the polyfill implementation. |
test/setup.ts |
Removes polyfill import; keeps Node-version-based fs.openAsBlob shim. |
src/utils.ts |
Refines isBinary into a TS type guard. |
src/SageHttpResponse.ts |
Updates docs and loosens constructor input typing. |
test/SageHttpResponse.spec.ts |
Removes as any casts now that constructor typing is looser. |
src/Sage.ts |
Adjusts header expectation logic (as part of refactor/reorder). |
test/request.spec.ts |
Updates cookie header expectations (SameSite=Lax appears). |
examples/fastify.spec.ts |
Updates cookie options + expected set-cookie header output. |
.vscode/settings.json |
Adds workspace TS SDK setting (currently uses a nonstandard key). |
.gitignore |
Ignores additional local tool artifacts. |
Comments suppressed due to low confidence (1)
package.json:80
- Bumping
fastifyto^5.7.4raises the minimum supported Node.js version (Fastify v5 and some transitive deps require Node >= 20). The repo still declaresengines.nodeas ">=18.0.0", so installs/tests on Node 18 will fail despite the declared support. Please alignengines.node(and CI/tooling) with the new minimum Node version required by these dependencies.
"express": "^4.21.2",
"fastify": "^5.7.4",
"form-data": "^4.0.4",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
- Coverage 94.93% 86.59% -8.34%
==========================================
Files 14 10 -4
Lines 2880 455 -2425
Branches 191 105 -86
==========================================
- Hits 2734 394 -2340
+ Misses 145 57 -88
- Partials 1 4 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.