Skip to content

Clarify Python/onnx inference usage - #262

Open
Ivan-267 wants to merge 4 commits into
mainfrom
Ivan-267-Improve-Python-Inference-Instructions
Open

Clarify Python/onnx inference usage#262
Ivan-267 wants to merge 4 commits into
mainfrom
Ivan-267-Improve-Python-Inference-Instructions

Conversation

@Ivan-267

@Ivan-267 Ivan-267 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Clarified instructions for which Sync node mode to select when using Python based vs ONNX inference. Partially addresses edbeeching/godot_rl_agents_plugin#69.

Ivan-267 added 3 commits July 10, 2026 16:02
Clarified instructions for Python inference
Clarified the description of the Training mode and added details about saving/exporting a model for inference.
@stefanfausser

Copy link
Copy Markdown
Contributor

LGTM.

Maybe the two sentences with "(onnx inference uses C# instead)" could be changed to "(ONNX inference uses a C# library in Godot instead)" because ONNX is an abbreviation for Open Neural Network Exchange and to clarify where ONNX inference is running. The original webpage (https://onnx.ai/onnx/intro/) also writes ONNX in capital cases.

Clarified instructions for Python inference in Godot Editor regarding the Control Mode and Onnx Inference.
@Ivan-267

Ivan-267 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

LGTM.

Maybe the two sentences with "(onnx inference uses C# instead)" could be changed to "(ONNX inference uses a C# library in Godot instead)" because ONNX is an abbreviation for Open Neural Network Exchange and to clarify where ONNX inference is running. The original webpage (https://onnx.ai/onnx/intro/) also writes ONNX in capital cases.

Thanks, I agree with that and used ONNX in other places where applicable.

In the latest commit I changed it to:

Set Onnx Inference if you want to run inference in Godot without Python (this mode uses C# instead).

I clarified it's talking about this "mode" in this change as ONNX inference can be done using other languages as well.
Onnx in that part (I know you were not referring to this one) is because that's how the property name shows in the inspector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants