Skip to content

Fix python issue found when using COMFIES ECFLOW-2100#351

Open
marcosbento wants to merge 8 commits into
developfrom
fix/python_for_comfies
Open

Fix python issue found when using COMFIES ECFLOW-2100#351
marcosbento wants to merge 8 commits into
developfrom
fix/python_for_comfies

Conversation

@marcosbento

@marcosbento marcosbento commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Description

As per PR title.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-351

@codecov-commenter

codecov-commenter commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.32886% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.89%. Comparing base (8dc9c6b) to head (7398ae2).

Files with missing lines Patch % Lines
libs/pyext/src/ecflow/python/PythonUtil.cpp 98.46% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #351   +/-   ##
========================================
  Coverage    50.88%   50.89%           
========================================
  Files         1239     1239           
  Lines        99248    99269   +21     
  Branches     14958    14958           
========================================
+ Hits         50505    50525   +20     
- Misses       48743    48744    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcosbento marcosbento force-pushed the fix/python_for_comfies branch from 612ee9b to cf35c1b Compare June 11, 2026 11:06
@marcosbento marcosbento changed the title Fix python issue found when using comfies Fix python issue found when using COMFIES ECFLOW-2100 Jun 11, 2026
@marcosbento marcosbento force-pushed the fix/python_for_comfies branch 4 times, most recently from 1321f65 to 05c7f61 Compare June 17, 2026 06:37
This effectively allows extend the ecflow Python objects, by adding
functions/properties to them.
This was the default when using Boost.python, but needs to be explicitly
defined when using Pybind11.

Re ECFLOW-2100
@marcosbento marcosbento force-pushed the fix/python_for_comfies branch from 05c7f61 to 7398ae2 Compare June 18, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants