Make PointSeries CoverageJSON spec compliant#125
Open
andreas-grafberger wants to merge 2 commits into
Open
Conversation
andreas-grafberger
marked this pull request as ready for review
July 17, 2026 08:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposes a relatively minimal fix for #122, and changes the
PointSeriesdomainType /TimeSeriesencoder/decoder to be CoverageJSON spec compliant.To keep this focused, I did not experiment with adding back pydantic support, and I only implemented this for
TimeSeries, not other encoders/decoders. Those should probably follow in future PRs to avoid any inconsistencies long-term.Changes:
0that was added so far stays in mars:metadata but not in the domain.[x, y], Gregorian TemporalRS for[t], optional VerticalCRS for[z].Contributor Declaration
By opening this pull request, I affirm the following: