DrHook gencore refactor#31
Draft
Andrew-Beggs-ECMWF wants to merge 11 commits into
Draft
Conversation
This lock relies on the filesystem to provide mutual exclusion & to be atomic. This is NOT a recursive lock and is (currently) unable to be unlocked. Use this with care.
Not actually needed as DrHook already has a pattern for locking using open(). This reverts commit 814f5cb.
This flag will allow any and all processes that abort, to create a core dump. This has killed even the most robust filesystem in the past when used incorrectly. As such, it will not be documented beyond this message & displays a massive warning to the user.
This commit contains WIP code. It is for review only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is about overhauling DrHook's core dump generation (or gencore). More detail to be added once the pr is stabilised & out of draft mode.