DrHook Static Linking Fixes#106
Merged
wdeconinck merged 58 commits intoMar 13, 2026
Merged
Conversation
This should allow for the testing of builds for both static and shared libs. If the case statement doesn't match (not currently possible), it will default to a shared lib build.
N.b. this is expected to fail due to missing libraries. That will be added later. Fix typo
It's common between ubuntu 24.04 and 22.04
Due to ROCm catching signals & looping
Also removes DR_HOOK_OPT=NOPROP since it is no longer needed.
Tests fail during CI due to the GitHub runner having no counters available. A minimal mock library should be made to solve this, but for now, simply having a working build that doesn't fail non-papi tests is sufficient. Fix regex Escape quotes Change quotes Replace case() statement Remove outer quotes Move regex to matrix to avoid string shenanigans Fix matrix defs Add quotes to avoid splitting Swap quotes Swap quotes Tmp test Add brackets for grouping Make regex more explicit
Change to ifdef vs literal value DR_HOOK_HAVE_PAPI isn't always defined. This is slightly safer too.
This is part of making a hotfix release. The intention is to drop this commit in a later PR.
wdeconinck
requested changes
Mar 10, 2026
Co-authored-by: Willem Deconinck <wdeconinck@me.com>
wdeconinck
added a commit
that referenced
this pull request
Mar 18, 2026
* release/2.0.0: (47 commits) Version 2.0.0 Add GSTATS CSV output Remove spurious cmake warning introduced in 0dfd9d6 Fix mpl_alltoallv missing target attribute (#107) (#108) DrHook Static Linking Fixes (#106) Fix warnings Fix scatterv test for nag (#103) Fix use of associate statement to optional argument in mpl_gatherv_int (#99) Fix hidden enabling of MPL_F77_DEPRECATED feature when MPI_F08 support is missing (#101) NAG support for --no-archive compiler option Set MPI_SERIAL_LIBRARIES --no-archive flags (#98) Fix missing target MPI::MPI_Fortran for static builds Update warning message and comment in mpl_displs_container_mod.F90 (#93) Also link MPI publicly for IntelLLVM (#94) fiatlib: update logic to ensure fiat lib target still exists in static builds (#96) Fix static linking (#95) Fixup #79, adding MPI as a dependency in fiat-import.cmake for NVHPC Fix meminfo for CCE/19.0.0 #92 Link MPI libraries publicly if building with NVHPC, to avoid symbol availability issue. * appears to be NVHPC-specific, NEEDS FURTHER INVESTIGATION Fix deadlock happening with ifx 2025.3.1 and make code more robust (#88) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is all the fixes, but none of the CI changes, from #104.
The easiest way I could think of to get all the required changes & keep the git history, was to simply have a commit that resets the changes to the CI. In the future, this commit could be dropped in an interactive rebase to restore the work done.