Build main against zenoh-flat-jni's snapshot, not an unreleased version - #702
Closed
milyin wants to merge 1 commit into
Closed
Build main against zenoh-flat-jni's snapshot, not an unreleased version#702milyin wants to merge 1 commit into
milyin wants to merge 1 commit into
Conversation
The nightly snapshot publication has never got past compiling:
Could not find org.eclipse.zenoh:zenoh-flat-jni:1.9.0
zenohFlatJniVersion named 1.9.0, which is not on Maven Central - nothing of
zenoh-flat-jni is, so no released version could have worked. Point it at the
snapshot zenoh-flat-jni's CI now publishes from its main, which is also what
puts the snapshot repository on the resolution path.
That makes an omitted zenoh-flat-jni-version resolve rather than fail, so the
guard against releasing against a snapshot has to move with it: check the value
gradle.properties ends up with instead of the workflow input, since an omitted
input is now exactly how a snapshot would reach a live release.
This was referenced Aug 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure
The nightly snapshot publication has never got past compiling —
run 31464385208:
zenohFlatJniVersion=1.9.0names a version that is not on Maven Central. Noreleased version could work: nothing of
zenoh-flat-jniis published yet. Theonly builds of it that exist are snapshots, and a non-snapshot version never
gets the snapshot repository on its resolution path — by design,
build.gradle.kts.#701documented the workaround (passzenoh-flat-jni-versionby hand for arehearsal). That does not help the two runs that pass no inputs at all: the
nightly snapshot publication in
ci.yml, and the scheduledrelease.yml.The change
zenohFlatJniVersion=1.9.0-SNAPSHOT— the snapshot zenoh-flat-jni's CIpublishes from its
main(CI: publish a snapshot from main, same rule as the other JVM repos zenoh-flat-jni#36). It is also whatturns on the snapshot repository here, so it is one property, not two.
bump-and-tag.bashnow checks the valuegradle.propertiesends up withrather than the workflow input. A live release still refuses a
-SNAPSHOTbinding — but an omitted
zenoh-flat-jni-versionis now exactly how one wouldreach a release, which the input-only check did not cover.
no longer true.
CI's test job is unaffected — it builds zenoh-flat-jni from source
(
-PuseLocalJni=true) and never touches a repository.Merge order
After eclipse-zenoh/zenoh-flat-jni#36 has run on its
mainand published1.9.0-SNAPSHOT. Until then this resolves no better than today. The mechanismitself is verified against a snapshot that does exist:
eclipse-zenoh/zenoh-java#523 is the same change.