feat: Implement support for PartTypeInformation 2.0.0 by OlgaIvkovic · Pull Request #1199 · eclipse-tractusx/puris

OlgaIvkovic · 2026-08-12T10:52:55Z

Description

Implement support for PartTypeInformation 2.0.0 submodel
Adjust endpoints for the PartTypeInformation Controller

Resolves #1193

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
Copyright and license header are present on all affected files (TRG 7.02)
Documentation Notice are present on all affected files (TRG 7.07)
If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).
Changelog updated (changelog.md) with PR reference and brief summary.
Frontend version bumped, if needed (frontend/package.json, frontend/package-lock.json)
Backend version bumped, if needed (backend/pom.xml)
Open API specification updated, if controllers have been changed (use python script scripts/generate_openapi_yaml.py with running customer backend)

+            return ProductLookup.error(HttpStatus.UNAUTHORIZED);
        }
-        log.info("{} requests part type information on {}", bpnl, materialnumber);
+        log.info("{} requests part type information {} on {}", bpnl, version, materialnumber);


+@NoArgsConstructor
+@ToString
+public class PartTypeInformationBody {
+    private LinkedHashSet<Classification> partClassification = new LinkedHashSet<>();


+    private PartTypeInformationBody partTypeInformation = new PartTypeInformationBody();
+
+    @Valid
+    private Set<PartSitesInformationAsPlanned> partSitesInformationAsPlanned = new HashSet<>();


ReneSchroederLJ

Thank you for the contribution. The functionality works well, but I suggested some simplifications.

ReneSchroederLJ · 2026-08-12T16:02:42Z

+
    private SubmodelData fetchPartTypeSubmodelData(MaterialPartnerRelation mpr) {
-        return fetchSubmodelData(mpr, "urn:samm:io.catenax.part_type_information:1.0.0#PartTypeInformation",
+        return fetchSubmodelData(mpr, AssetType.PART_TYPE_INFORMATION_SUBMODEL.URN_SEMANTIC_ID,


I only now realize how unncessary these methods are. getSubmodelFromPartner should simply call fetchSubmodelData directly for the correct semantic id

ReneSchroederLJ · 2026-08-12T16:05:41Z

+        return fetchCxId(mpr, AssetType.PART_TYPE_INFORMATION_LEGACY_SUBMODEL, "catenaXId");
+    }
+
+    private String fetchCxId(MaterialPartnerRelation mpr, AssetType type, String cxIdProperty) {


I would prefer determining the cxIdProperty with a switch statement for AssetType. That simplifies the passed properties and can also be used to prevent wrong AssetTypes from being used here.

ReneSchroederLJ · 2026-08-12T16:12:36Z

        return dataAddress;
    }

+    public JsonNode buildPartTypeInfoLegacySubmodelRegistrationBody() {


I know at the moment we're handling the building of the body for PartTypeInformation separately. However this was already outdated previously. Please utilize the generic buildSubmodelRegistrationBody for both and remove the special methods.

ReneSchroederLJ · 2026-08-12T16:19:47Z

+        if (lookup.failed()) {
+            return ResponseEntity.status(lookup.error()).build();
        }


Suggested change

if (lookup.failed()) {

return ResponseEntity.status(lookup.error()).build();

}

if (lookup.error != null) {

return ResponseEntity.status(lookup.error).build();

}

ReneSchroederLJ · 2026-08-12T16:20:27Z

+        if (lookup.failed()) {
+            return ResponseEntity.status(lookup.error()).build();
+        }


Suggested change

if (lookup.failed()) {

return ResponseEntity.status(lookup.error()).build();

}

if (lookup.error != null) {

return ResponseEntity.status(lookup.error).build();

}

ReneSchroederLJ · 2026-08-12T16:31:11Z

+import java.util.Set;
+
+import org.eclipse.tractusx.puris.backend.common.util.PatternStore;
+import org.eclipse.tractusx.puris.backend.masterdata.logic.dto.parttypeinformation.v1.PartTypeInformationLegacySAMM;


Suggested change

import org.eclipse.tractusx.puris.backend.masterdata.logic.dto.parttypeinformation.v1.PartTypeInformationLegacySAMM;

ReneSchroederLJ · 2026-08-12T16:34:48Z

This file is used by both versions. It should either be moved to a common folder or be duplicated per version. For now I would move it to a common folder at the same level as the version folders

ReneSchroederLJ · 2026-08-12T16:38:06Z

I don't think it makes sense to separate these test cases into a new file since they test the same file.

Since the names of the files are the same for v1 and v2, the imports would get confused if all of the tests were in a single file

You can use the fully qualified names for the v1 versions. So for example PartSiteInformationAsPlanned becomes org.eclipse.tractusx.puris.backend.masterdata.logic.dto.parttypeinformation.v1.PartSitesInformationAsPlanned

ReneSchroederLJ · 2026-08-12T16:39:40Z

@@ -53,7 +53,7 @@ tests {
  test("Verify response contains six data offers", function () {


please also fix this test description and add the missing 2 submodels part type information legacy and days of supply.

ReneSchroederLJ · 2026-08-12T16:40:10Z

@@ -54,7 +54,7 @@ tests {
  test("Verify response contains six data offers", function () {
      expect(contractOffers).to.be.an("array");
      // dtr, part type information, stock, demand, delivery, production


same as above. please fix the description and comment,

ReneSchroederLJ

Thanks for incorporating. Just found 3 very minor things to fix

ReneSchroederLJ · 2026-08-13T19:13:29Z

        result &= createSubmodelContractDefinitionForPartner(AssetType.DATA_EXCHANGE_REQUEST.URN_SEMANTIC_ID, variablesService.getDataExchangeRequestApiAssetId(), partner);
        result &= createSubmodelContractDefinitionForPartner(AssetType.DAYS_OF_SUPPLY.URN_SEMANTIC_ID, variablesService.getDaysOfSupplySubmodelApiAssetId(), partner);
-        return createSubmodelContractDefinitionForPartner(AssetType.PART_TYPE_INFORMATION_SUBMODEL.URN_SEMANTIC_ID, variablesService.getPartTypeSubmodelApiAssetId(), partner) && result;
+        result &= createSubmodelContractDefinitionForPartner(AssetType.PART_TYPE_INFORMATION_SUBMODEL.URN_SEMANTIC_ID, variablesService.getPartTypeSubmodelApiAssetId(), partner) && result;


Suggested change

result &= createSubmodelContractDefinitionForPartner(AssetType.PART_TYPE_INFORMATION_SUBMODEL.URN_SEMANTIC_ID, variablesService.getPartTypeSubmodelApiAssetId(), partner) && result;

result &= createSubmodelContractDefinitionForPartner(AssetType.PART_TYPE_INFORMATION_SUBMODEL.URN_SEMANTIC_ID, variablesService.getPartTypeSubmodelApiAssetId(), partner);

ReneSchroederLJ · 2026-08-13T19:29:03Z

    public ResponseEntity<PartTypeInformationSAMM> getMapping(@RequestHeader("edc-bpn") String bpnl,
                                                              @Parameter(description = "The material number that the request receiving party uses for the material in question")
                                        @PathVariable String materialnumber,
                                                              @Parameter(description = "Must be set to '$value'") @PathVariable String representation) {


Please fix the formatting of the method parameters for this endpoint and the other a bit. It's very confusing to read at the moment

ReneSchroederLJ · 2026-08-13T19:31:30Z

+     * @return                  the resolved product or the status to be returned to the partner
+     */
+    private ProductLookup resolveProduct(String bpnl, String materialnumber, String representation, String version) {
+        materialnumber = new String(Base64.getDecoder().decode(materialnumber.getBytes(StandardCharsets.UTF_8)));


This statement should be wrapped in a try catch block since an invalid base64 will throw an exception

OlgaIvkovic added 2 commits August 12, 2026 12:50

feat: Implement support for PartTypeInformation 2.0.0

668ccbe

chore: update changelog

80e308f

github-advanced-security AI found potential problems Aug 12, 2026

View reviewed changes

OlgaIvkovic requested a review from ReneSchroederLJ August 12, 2026 11:33

ReneSchroederLJ requested changes Aug 12, 2026

View reviewed changes

change: apply pr fixes

707b01b

OlgaIvkovic requested a review from ReneSchroederLJ August 13, 2026 09:34

ReneSchroederLJ requested changes Aug 13, 2026

View reviewed changes

ReneSchroederLJ marked this pull request as ready for review August 13, 2026 20:31

		@@ -53,7 +53,7 @@ tests {
		test("Verify response contains six data offers", function () {

	result &= createSubmodelContractDefinitionForPartner(AssetType.PART_TYPE_INFORMATION_SUBMODEL.URN_SEMANTIC_ID, variablesService.getPartTypeSubmodelApiAssetId(), partner) && result;
	result &= createSubmodelContractDefinitionForPartner(AssetType.PART_TYPE_INFORMATION_SUBMODEL.URN_SEMANTIC_ID, variablesService.getPartTypeSubmodelApiAssetId(), partner);

Uh oh!

Conversation

OlgaIvkovic commented Aug 12, 2026

Description

Pre-review checks

Uh oh!

ReneSchroederLJ left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ReneSchroederLJ left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants