Feat/data exchange forward - #1198
Open
OlgaIvkovic wants to merge 4 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ReneSchroederLJ
requested changes
Aug 13, 2026
ReneSchroederLJ
left a comment
ReneSchroederLJ
left a comment
Member
There was a problem hiding this comment.
Thank you for the contribution. The code itself is fine for the most part. Small improvements and one possible security issue.
| return; | ||
| } | ||
|
|
||
| List<OwnDataExchangeRequest> siblings = ownDataExchangeRequestService.findByRelatedDataExchangeRequest(origin); |
Member
There was a problem hiding this comment.
semantically these should be children of the original ReportedDataExchangeRequest right?
| log.error("Failed to finalize approval {}", originApproval.getApprovalId()); | ||
| return; | ||
| } | ||
| Partner customer = origin.getNotification().getPartner(); |
Member
There was a problem hiding this comment.
Suggested change
| Partner customer = origin.getNotification().getPartner(); | |
| Partner partner = origin.getNotification().getPartner(); |
| .desiredStartDateTime(target.start()) | ||
| .desiredEndDateTime(target.end()) | ||
| .requestedTypes(new ArrayList<>(origin.getRequestedTypes())) | ||
| .text(origin.getText()) |
Member
There was a problem hiding this comment.
For security reasons we can not use the same text for the forwarded requests. I would suggest a generic text for now like: "Forwarded data exchange request from a downstream partner"
Comment on lines
+170
to
+175
| if (forward) { | ||
| for (OwnDataExchangeRequest fwd : dataExchangeForwardService.createForwardedRequests(reportedRequest, targets)) { | ||
| Partner target = fwd.getNotification().getPartner(); | ||
| executorService.submit(() -> dataExchangeRequestApiService.sendDataExchangeRequest(fwd, target)); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (forward) { | |
| for (OwnDataExchangeRequest fwd : dataExchangeForwardService.createForwardedRequests(reportedRequest, targets)) { | |
| Partner target = fwd.getNotification().getPartner(); | |
| executorService.submit(() -> dataExchangeRequestApiService.sendDataExchangeRequest(fwd, target)); | |
| } | |
| } | |
| for (OwnDataExchangeRequest fwd : dataExchangeForwardService.createForwardedRequests(reportedRequest, targets)) { | |
| Partner target = fwd.getNotification().getPartner(); | |
| executorService.submit(() -> dataExchangeRequestApiService.sendDataExchangeRequest(fwd, target)); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates #1192
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
changelog.md) with PR reference and brief summary.frontend/package.json,frontend/package-lock.json)backend/pom.xml)scripts/generate_openapi_yaml.pywith running customer backend)