feat: update demand and capacity notification version to 3.0.0 - #1197
Open
ruzicam8020 wants to merge 2 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| try { | ||
| log.info("Received POST request for DemandAndCapacityNotification 2.0.0 with BPNL: " + bpnl); | ||
| log.info("Received POST request for DemandAndCapacityNotification 3.0.0 with BPNL: " + bpnl); |
ReneSchroederLJ
requested changes
Aug 13, 2026
ReneSchroederLJ
left a comment
ReneSchroederLJ
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution. Overall very solid work I just found some unused parameters and you accidentally pushed a log file.
| return parseContent(body.get("content"), expectedContext, contentType); | ||
| } | ||
|
|
||
| private <T> T parseContent(JsonNode content, IndustryCoreMessageContext context, Class<T> contentType) { |
Member
There was a problem hiding this comment.
Suggested change
| private <T> T parseContent(JsonNode content, Class<T> contentType) { |
| throw new IllegalArgumentException("Body is missing"); | ||
| } | ||
| validate(body.get("header"), senderBpn, expectedContext); | ||
| return parseContent(body.get("content"), expectedContext, contentType); |
Member
There was a problem hiding this comment.
Suggested change
| return parseContent(body.get("content"), contentType); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #1194
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
changelog.md) with PR reference and brief summary.frontend/package.json,frontend/package-lock.json)backend/pom.xml)scripts/generate_openapi_yaml.pywith running customer backend)