feat: bring your own wallet - #1422
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
typecastcloud
left a comment
typecastcloud
left a comment
There was a problem hiding this comment.
Some formatting issues I found. Also please take a look at codeql findings.
dhiren-singh-007
left a comment
dhiren-singh-007
left a comment
There was a problem hiding this comment.
I have done the review and approving the PR.
@ntruchsess Can you please have a look also?
0c67cbf to
9b1f62e
Compare
|
|
as aligned in the portal meeting @ntruchsess will start the review as soon as possible |
typecastcloud
added
the
merge postponed
|
@MaximilianHauer @ntruchsess can we pls close this ticket? or do you still want to review or add anything? |
The feature is implemented and tested from our side. We are still waiting from a PR review or a decision to merge it. @MaximilianHauer @dhiren-singh-007 Could we merge it? |
@leandro-cavalcante I have already approved the PR and i was waiting for the feedback from @ntruchsess as mentioned by @MaximilianHauer here #1422 (comment) |
|
@dhiren-singh-007 as i remember a review was requested by norbert but due to capacity limitations we could not support here. i dont have any stackes on this topic . |
feat: add support for bring your own wallet in issuer credentials feat: CS 3640 add controller to validate did (#2) Co-authored-by: Shumaila Malik <shumaila.malik@cofinity-x.com> Co-authored-by: Nitin <nitin.vavdiya@smartsensesolutions.com> Added step to trasmit the did to other systems Added the correct step during on board process for byow Updated the updated bpn to also check BYOW Created an endpoint to save the did number and refoctor the registration business logic removed uncessary parameter on the endpoint byow Added necessary parameter for resolver did Extracting correct did http address and enhanced tests fix: added check for missing configuration fix: added implementation to avoid duplicate dids Feat: Added restrictions user roles for BYOW and Tests fix: reverted changes for technical user request and changes exception types for universal resolver feat: added example of configuratio for universal resolver Update src/registration/Registration.Service/BusinessLogic/BringYourOwnWalletBusinessLogic.cs Co-authored-by: Karsten Thiems <karsten.thiems@cofinity-x.com> Update src/registration/Registration.Service/Controllers/BringYourOwnWalletController.cs Co-authored-by: Karsten Thiems <karsten.thiems@cofinity-x.com> fix: resolved codeql findings Update src/Portal.Backend.sln Co-authored-by: Karsten Thiems <karsten.thiems@cofinity-x.com> fix: resolved codeql findings fix: resolved pr requests fix: removed codeql warning for user-controlled data Revert "fix: removed codeql warning for user-controlled data" This reverts commit bb0a4ad. fix: removed codeql warning for user-controlled data fix: removed user-controlled bypass sensitive method Revert "fix: removed user-controlled bypass sensitive method" This reverts commit 1ef3e66. fix: enhanced the use of exceptions and updated tests fix: split tests to cover pr review fix: added logic on bpdm business logic when byow active fix: adding the standard format for the path of the library fix: added starndard format to the path of the library fix: Revert automatic formatting fix: updating the dependencies file fix: updating the depencies file generated fom pipeline fix: filtering possible unauthorized user role provided by the user fix: fixing user bypass control during user role validation fix: refactoring the code to avoid user bypass controller fix: combined if statements
ce4bf72 to
6a08814
Compare
|
0055d51
into
eclipse-tractusx:main
| }, | ||
| "BringYourOwnWallet": { | ||
| "NonApplicableUserRoles": [ | ||
| "607818be-4978-41f4-bf63-fa8d2de51158" |
There was a problem hiding this comment.
Is this id wrong here?
Similar to here:
eclipse-tractusx/portal#555 (comment)
6 participants
Description
As a part of Bring Your Own Wallet (BYOW) efforts within the Catena-X to decentralize the wallet ecosystem in the network, it is necessary for some of the Tractus-X components (i.e., Portal Backend, ssi-credential-issuer) to foster this movement.
Onboarding Processes must be adapted for portal backend and frontend
Why
Issue
Link to Github issue 1160.
Checklist
Please delete options that are not relevant.