Skip to content

ci(quality-checks): introduce quality checks workflow - #1372

Open
tom-rm-meyer-ISST wants to merge 13 commits into
mainfrom
ci/prepare-notice-file
Open

ci(quality-checks): introduce quality checks workflow#1372
tom-rm-meyer-ISST wants to merge 13 commits into
mainfrom
ci/prepare-notice-file

Conversation

@tom-rm-meyer-ISST

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Description

This PR shall support the committers in ensuring the open-source policies by making use of the 1.3.x release guideline automation. For non-product repositories it can check for missing / incorrect notice sections.

I provided an initial configuration:

  • exclude
    • all kits (except puris / scdn)
    • blog/
    • blog-changelog/
    • blog-meeting-minutes/

Currently excluded but to be discussed:

  • docs/ includees release (TRG), oss, website-guidelines, tutorials, etc
  • CONTRIBUTING.md

2026-08-13: Just reiterated it. Did plenty of additional stuff to ensure puris and scdn are fine (overshooted)

  • license files in the past are fine (also in verisoned source url)
  • fixed pipelines (markdown lint hitting source url bare url in markdown link)
  • merged + covering the versions that came in between

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@matbmoser matbmoser added the stale Items without activities label Jun 10, 2026
@tom-rm-meyer-ISST
tom-rm-meyer-ISST marked this pull request as ready for review August 13, 2026 17:25
@tom-rm-meyer-ISST

Copy link
Copy Markdown
Contributor Author

@stephanbcbauer this took me more time than I wanted now. I optimized nearly to the end and way to much.

A thing I noticed: source url is often missing and h2 note is often not fully uppercased. Maybe we want to allow Note too?

@stephanbcbauer

Copy link
Copy Markdown
Member

@stephanbcbauer this took me more time than I wanted now. I optimized nearly to the end and way to much.

A thing I noticed: source url is often missing and h2 note is often not fully uppercased. Maybe we want to allow Note too?

Would work for me. How much effort would it be to allow it? We could restrict it later on :)

@stephanbcbauer
stephanbcbauer requested a balanced review from Copilot August 13, 2026 17:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@tom-rm-meyer-ISST

Copy link
Copy Markdown
Contributor Author

@stephanbcbauer this took me more time than I wanted now. I optimized nearly to the end and way to much.
A thing I noticed: source url is often missing and h2 note is often not fully uppercased. Maybe we want to allow Note too?

Would work for me. How much effort would it be to allow it? We could restrict it later on :)

It's already restricted. Allowing it is around an hour for me and some time for you. We would need to update the tooling in https://github.com/eclipse-tractusx/sig-release and do releases of the tool and action / workflow. The pipeline uses the latest available action.

@stephanbcbauer

Copy link
Copy Markdown
Member

Than let's do the no effort version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Items without activities

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

4 participants