Add structured issue form with auto-labeling on intake - #17901
Draft
ankitsharma101 wants to merge 11 commits into
Draft
Add structured issue form with auto-labeling on intake#17901ankitsharma101 wants to merge 11 commits into
ankitsharma101 wants to merge 11 commits into
Conversation
Fixes eclipse-theia#16865 Multiple consecutive spaces in file and folder names were being collapsed to single spaces in tree views due to white-space: nowrap. Changed white-space from 'nowrap' to 'pre' in .theia-TreeNodeSegment and .theia-TreeNodeSegmentGrow in packages/core/src/browser/style/tree.css to preserve exact spacing in all tree views.
Fixes eclipse-theia#12619 When you resize the window while a dropdown is open in the preferences page, the dropdown stays open but the positioning gets messed up. I added a resize listener that closes the dropdown when the window size changes. Also made sure to clean up the listener properly to avoid any memory leaks. Note: I couldn't test this locally (Windows build issues), but the approach is pretty standard for this kind of thing. Would appreciate if someone could verify it works!
… backendPluginsMetadataDeferred never resolving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Implements the structured issue form + auto-label suggestion from the onboarding/issue-tracking proposal (Discussion #17639), addressing the label-inconsistency problem described in Section 2.3 of that proposal — issues currently get labeled "bug" / "type: bug" / just a title prefix, or not labeled at all.
Adds:
.github/ISSUE_TEMPLATE/report.yml— a structured issue form with a required Type dropdown (Bug / Feature / Enhancement). Consolidates the previousbug_report.mdandfeature_request.mdtemplates into this single form..github/workflows/auto-label-on-intake.yml— a GitHub Action that reads the Type dropdown's answer when an issue is opened and applies the matching label (bug/enhancement) automatically.Note: "Question" isn't in the Type dropdown, since
config.ymlalready routes questions to GitHub Discussions viacontact_links— this avoids duplicating that path. The security-vulnerability disclosure warning frombug_report.mdis preserved in the new form.A call worth flagging: I merged the two existing templates into one rather than keeping them side-by-side with the new form. Reasoning — a single entry point removes the "which template do I pick" ambiguity that a structured Type field is meant to solve in the first place (I actually picked the wrong template myself while testing, out of habit). Happy to keep the old templates around instead if the team prefers a more gradual rollout.
How to test
Issues → New Issue— only one template, "Issue Report," should appear (blank issues are already disabled via existingconfig.yml).bugorenhancement) applied automatically, with no manual step.Tested end-to-end on my fork (ankitsharma101/theia) — form renders correctly, submission triggers the Action, and the correct label is applied.
Follow-ups
featurelabel currently exists in the repo, so both "Feature" and "Enhancement" map to the existingenhancementlabel. If the team wants a dedicatedfeaturelabel, the mapping inauto-label-on-intake.ymlis a one-line change.Breaking changes
(Not a breaking change — it only affects the issue-filing UI and automated labeling; no code paths in the application itself are touched.)
Attribution
—
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers