Skip to content

Rust::com enable the CI Job for rust lint check#523

Open
bharatGoswami8 wants to merge 2 commits into
eclipse-score:mainfrom
bharatGoswami8:enable_clippy_lint_CI_job
Open

Rust::com enable the CI Job for rust lint check#523
bharatGoswami8 wants to merge 2 commits into
eclipse-score:mainfrom
bharatGoswami8:enable_clippy_lint_CI_job

Conversation

@bharatGoswami8

@bharatGoswami8 bharatGoswami8 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

GitHub Actions workflow that runs Rust linter on pull requests to enforce code quality standards.

Key Features

  • Only runs when PR has .rs rust files or workflow of lint changed
  • Only fails on warnings/errors in files you changed, not pre-existing issues
  • Treats Warnings as Errors
  • Job summary shows issue count + code snippets from changed files
  • Full Build log available for download

When It Runs

  • Pull requests with .rs rust files or workflow of lint changes
  • Pushes to main
  • Merge queue checks

Fail Job Example available here - https://github.com/bharatGoswami8/communication/actions/runs/27337081555/job/80763973850?pr=1

@bharatGoswami8 bharatGoswami8 self-assigned this Jun 10, 2026
@bharatGoswami8 bharatGoswami8 force-pushed the enable_clippy_lint_CI_job branch 5 times, most recently from b6c1fc2 to 9d1d7a7 Compare June 11, 2026 06:07
@bharatGoswami8 bharatGoswami8 marked this pull request as ready for review June 11, 2026 06:12
* Added workflow yml
* Updated bzlrc file
@bharatGoswami8 bharatGoswami8 force-pushed the enable_clippy_lint_CI_job branch from 9d1d7a7 to a7398da Compare June 11, 2026 06:15
@bharatGoswami8 bharatGoswami8 changed the title Rust::com enable the CI Job for clippy lint check Rust::com enable the CI Job for rust lint check Jun 11, 2026

@LittleHuba LittleHuba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I'll do some general feedback first.
Please change the trigger conditions. Avoid hiding this behind the rust-api label, since this puts load on maintainers to label PRs correctly. We only use the labeling approach for QNX since it helps with the security implications of pull-request-target triggers.

Better filter PRs for changes to specific path patterns. E.g. PRs that touch files with ending .rs. That would achieve the same but automatically.

* Auto enable CI Job when changes in rust file or workflow
@bharatGoswami8

Copy link
Copy Markdown
Contributor Author

Hi, I'll do some general feedback first. Please change the trigger conditions. Avoid hiding this behind the rust-api label, since this puts load on maintainers to label PRs correctly. We only use the labeling approach for QNX since it helps with the security implications of pull-request-target triggers.

Better filter PRs for changes to specific path patterns. E.g. PRs that touch files with ending .rs. That would achieve the same but automatically.

@LittleHuba , I have updated pre-check condition now Job will run only when either rust files or workflow of lint is changed or updated on PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants