feat(mw::com): Implement Field Notifier support for Generic Skeleton#455
Open
ShoroukRamzy wants to merge 4 commits into
Open
feat(mw::com): Implement Field Notifier support for Generic Skeleton#455ShoroukRamzy wants to merge 4 commits into
ShoroukRamzy wants to merge 4 commits into
Conversation
ShoroukRamzy
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
ShoroukRamzy
force-pushed
the
generic_skeleton_field_notifier
branch
from
1cb68f8 to
e8cdd9f
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If this PR is still relevant, please leave a comment or push new changes to keep it open. |
Contributor
Author
Hi @crimson11, Could you please have a look when you have time? Thanks! |
ShoroukRamzy
force-pushed
the
generic_skeleton_field_notifier
branch
from
e8cdd9f to
ae65f9d
Compare
ShoroukRamzy
force-pushed
the
generic_skeleton_field_notifier
branch
from
ae65f9d to
aa82c73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR extends the GenericSkeleton to support type-erased Fields and solves this issue #181
Key Changes:
GenericSkeletonField: Introduced as a type-erased facade for fields. It takes ownership of a GenericSkeletonEvent under the hood to handle shared memory interactions and broadcasts.
Initial Value Caching: Calling Update() before OfferService() caches the field payload locally. Once the service is offered, DoDeferredUpdate() automatically allocates memory and dispatches this initial value to subscribers.
Zero-copy Notifications: Added support for Allocate() and Update(SampleAllocateePtr) to push new field values to subscribers after the service is actively running.
Skeleton Orchestration: Updated GenericSkeleton::Create to parse field configurations, spawn the fields, and properly populate the internal fields_ map.
Next Steps / Future Work:
Generic Getters & Setters: Currently, RegisterGetHandler and RegisterSetHandler are stubbed out as WIP and return ComErrc::kCouldNotExecute. In the next step, this generic field will be extended with full set and get method support over shared memory once those features are fully implemented.