mw/com: Make ProxyBase::AreBindingsValid symmetrical with Skeleton side#414
mw/com: Make ProxyBase::AreBindingsValid symmetrical with Skeleton side#414bemerybmw wants to merge 2 commits into
Conversation
bemerybmw
requested review from
LittleHuba,
castler,
crimson11,
hoe-jo and
limdor
as code owners
|
The removal of EventBindingRegistrationGuard would happen later? |
Yep, that's happening in the next change that I'm working on. |
bemerybmw
force-pushed
the
brem_fix_event_registration_impl
branch
from
fe22c01 to
d496d88
Compare
| Instead, they only set once (see above) the `ProxyBase::are_service_element_bindings_valid_` member variable of their | ||
| parent during construction as this is currently the only feedback needed between proxy and its proxy events on binding | ||
| independent level. | ||
| Similarly to the skeleton side, the `impl::SkeletonBase` doesn't "know" its event/field/method children. Therefore, |
There was a problem hiding this comment.
impl::SkeletonBase
impl::ProxyBase
|
|
||
| #### Binding level Registration of proxy events/fields at their parent proxy | ||
|
|
||
| On the binding **specific** level things look different! |
There was a problem hiding this comment.
Does this sentence now make sense anymore? So there is no difference between binding-specific/binding-unspecific level anymore? In both cases the proxy knows its childs, because on both levels this registration process takes place ...
|
|
||
| // Expecting that StartFindService is called and synchronously calls handler since provider exists | ||
| EXPECT_CALL(service_discovery_mock_, StartFindService(_, EnrichedInstanceIdentifier{identifier_})) | ||
| .WillOnce(WithArg<0>(Invoke([valid_find_service_handle, this](auto find_service_handler) noexcept { |
There was a problem hiding this comment.
Nitpicky:
.WillOnce(InvokeArgument<0>([valid_find_service_handle, this](auto find_service_handler) noexcept {
is a lot clearer ;)
There was a problem hiding this comment.
I don't think this works. I think this is intended to call the argument directly but we rather need to do some prep, call the callable and then return a value (via a lambda). From the docs, I think InvokeArgument was added before c++ had lambdas.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If this PR is still relevant, please leave a comment or push new changes to keep it open. |
|
This pull request has been automatically closed due to inactivity. Feel free to reopen it if you would like to continue working on it. |
Previously, ProxyBase::AreBindingsValid was implemented differently to avoid have to store a map of service elements (which also requires updating the map when moving a Proxy) in ProxyBase. However, we have since added these maps so there's no longer any reason to have the asymmetry in the implementations of AreBindingsValid.
Previously, the event binding was registered from the binding independent level via a function in the bindings interface. We change this so that the registration is done completely on the binding level to simplify the interface and also to allow each binding to decide whether it needs to register events with the parent proxy. This is now inline with how we handle registration for methods. This also fixes an issue that the EventRegistrationGuard was accessing the Proxy binding from the context of a ProxyEvent's destructor. When move assigning a skeleton, the ProxyBase move assignment operator will be called before that of the ProxyEvent, so the pointer to the Proxy binding would be invalid when calling UnregisterEventBinding.
bemerybmw
force-pushed
the
brem_fix_event_registration_impl
branch
from
d496d88 to
79ce5f1
Compare
3 participants
Previously, ProxyBase::AreBindingsValid was implemented differently to avoid have to store a map of service elements (which also requires updating the map when moving a Proxy) in ProxyBase. However, we have since added these maps so there's no longer any reason to have the asymmetry in the implementations of AreBindingsValid.