Finish removal of deprecated runtime contentTypes extension point#2769
Open
vogella wants to merge 1 commit into
Open
Finish removal of deprecated runtime contentTypes extension point#2769vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
The org.eclipse.core.runtime.contentTypes declaration and schema were removed earlier, but the runtime still read and listened for the point. Drop the dead back-compat branch in ContentTypeBuilder and the matching registry listener in ContentTypeManager, migrate the performance test to org.eclipse.core.contenttype.contentTypes, and remove the now-orphaned contentTypesName label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
org.eclipse.core.runtime.contentTypesextension point and its schema were removed earlier, but the runtime still read from that point and registered a registry-change listener for it.This change drops the dead back-compatibility branch in
ContentTypeBuilderand the matching listener wiring inContentTypeManager, so the runtime only consumes the long-establishedorg.eclipse.core.contenttype.contentTypespoint.It also migrates the content type performance test, which contributed to the old point and would otherwise register nothing, and removes the now-orphaned
contentTypesNamelabel from the runtimeplugin.properties.All edits are in internal classes, a test, and a resource file, so there is no public API change.