Skip Quick Access recompute on no-op resize#4090
Open
vogella wants to merge 1 commit into
Open
Conversation
Contributor
Test Results 861 files ±0 861 suites ±0 46m 38s ⏱️ + 1m 7s For more details on these failures, see this check. Results for commit 95c98c9. ± Comparison against base commit a4171b1. ♻️ This comment has been updated with latest results. |
QuickAccessContents armed a recompute on every shell resize during the popup's initial layout, and each recompute cancels the in-flight compute job. On Windows the native search field triggers a burst of initial layout resizes, so the compute job scheduled for freshly typed text was repeatedly cancelled and the table was never refreshed. This is the intermittent failure in QuickAccessDialogTest.testPreviousChoicesAvailableForExtension. A resize only changes the results by changing how many rows fit, so track the row count used for the last compute and skip the resize-triggered update when it is unchanged. Remaining resizes are coalesced with a trailing-edge debounce so a burst (for example scrollbar oscillation during initial layout) collapses into a single update once the layout settles, instead of cancelling the in-flight compute job repeatedly. Also fix an accidental ~83 minute timeout (TIMEOUT * 1000) in that test's dialog-init wait. Fixes eclipse-platform#4009
vogella
force-pushed
the
lv/quickaccess-resize-race
branch
from
72c969b to
95c98c9
Compare
Contributor
Author
|
The test failure due to the process kill on the Mac seems unrelated, maybe some ongoing releng work or just a infrastructure hickup? cc @HannesWell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the Quick Access popup's initial layout, every shell resize re-triggered the proposal computation, and each recompute cancels the job still in flight. On Windows the native search field produces a burst of layout resizes, so the computation for freshly typed text kept getting cancelled and the result table was never populated, which is the intermittent failure of
testPreviousChoicesAvailableForExtension.A resize only affects results when it changes how many rows fit, so the dialog now records the row count it last computed for and skips the resize-triggered recompute when that count is unchanged, removing the cancellation path. This also drops the redundant recompute on cosmetic resizes during normal use. Finally it fixes an accidental ~83 minute timeout (
TIMEOUT * 1000) in that test's dialog-init wait.Fixes #4009