Feature/foreground service - #418
Open
MGasztold wants to merge 6 commits into
Open
Conversation
Signed-off-by: MGasztold <michal.gasztold@ubudu.com>
Signed-off-by: MGasztold <michal.gasztold@ubudu.com>
Signed-off-by: MGasztold <michal.gasztold@ubudu.com>
MGasztold
force-pushed
the
feature/foreground-service
branch
from
July 7, 2020 20:14
1a60744 to
b7ce5e3
Compare
Signed-off-by: MGasztold <michal.gasztold@ubudu.com>
MGasztold
force-pushed
the
feature/foreground-service
branch
from
July 16, 2020 11:58
9e23d1d to
8967ddf
Compare
jabulenc
approved these changes
Aug 25, 2020
Signed-off-by: MGasztold <michal.gasztold@ubudu.com>
ArikYa
approved these changes
Aug 25, 2020
|
Hi, what is the status of this pull request? I need the foreground service capabilities. Thanks. |
Author
|
@alexwijoyo Hello, I am successfully using it in my project. I do not know what is left |
|
Hello, I really need this pull request in my project, I'm having some problems with foreground services. |
Author
|
Anybody knows whose attention should I get in order to make this pull request be merged? |
|
@MGasztold I will try to incorporate your fork library source to my project. Thanks. |
Afflya
pushed a commit
to Afflya/paho.mqtt.android
that referenced
this pull request
Oct 30, 2020
Signed-off-by: chowen <chowen.dev@gmail.com>
Afflya
pushed a commit
to Afflya/paho.mqtt.android
that referenced
this pull request
Oct 30, 2020
…because app is in background
|
Is this going to get merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please make sure that the following boxes are checked before submitting your Pull Request, thank you!
This pull requests solves issues with Android versions >=8 in which service is killed by OS when app is in background or after screen is turned off. The price to pay for this is the notification that has to be permanently visible in the app's status bar.
The API I proposed let's developer start MQTT service as foreground service and provide its own Notification object. In the same time it is totally optional.
I also got rid of legacy support library dependency in favor of latest androidx dependency.
This pull requests tries to solve the following issues:
#416 #332 #281 #274 #226