chore(webui): adding prettier#1916
Open
gnugomez wants to merge 3 commits into
Open
Conversation
Member
Author
|
@amvanbaren I know you added https://eslint.style/ not too long ago to the project, although not many formatting was happening, was this intended? I'm creating this PR because while working on some patches it got really painful to get things formatted. Things like JSX was not really being formatted. Overall it felt quite inconsistent. |
gnugomez
commented
Jun 16, 2026
| parser: tsParser, | ||
| }, | ||
|
|
||
| settings: { |
Member
Author
There was a problem hiding this comment.
note: I'm moving this out since was producing some warnings bc react config was not scoped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem we're facing right now is that despite we do have some stylistic rules we were not enforcing a full config, meaning that we did not had much formatting rules working, those were really minimal and don't provide help most of the time to keep code formatting consistent.
I tailored a prettier config to reduce how many changes will it produce, although 169 files will be affected.
I'm replacing
@stylistic/eslint-pluginwith prettier since it's provides a wider more opinionated formatting.To keep things consistent to how we were working up to now I made prettier work through eslint, this way we will only run prettier once per file.