Change: add check for unsafe paths to MaliciousZipCheckService#1915
Merged
Conversation
gnugomez
reviewed
Jun 16, 2026
autumnfound
reviewed
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an additional check to the
MaliciousZipCheckServicefor potentially unsafe entry names.Any extension containing entries with such names are rejected immediately.
As a consequence, the
ArchiveUtil.isSafePathis not called anymore from theSecretCheckServiceandBlocklistCheckServiceas they will only operate on extensions that are considered to be safe.The
ArchiveUtil.isSafePathmethod has also been further extended for additional unsafe patterns, accompanied by unit tests/