ci: improve pipeline parameters defaults handling#14
Merged
Conversation
pierantoniomerlino
approved these changes
Apr 15, 2026
pierantoniomerlino
added a commit
that referenced
this pull request
Apr 15, 2026
This reverts commit 88d4365.
mattdibi
added a commit
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current main branch only implements shallow merging of the parameters provided by the user and the default parameters.
This means that, if a user calls the pipeline with:
the
pipelineParams.toolchain.mavenvariable will be set tonullinstead of falling back to the default.This PR introduces a
deepMergefunction which handles the correct merging of the two maps and therefore results in a more logical behaviour and a better user experience.