Fix the existing tests for invalid input - #77
Merged
atextor merged 4 commits intoJul 29, 2026
Conversation
Hanna-Shalamitskaya-EPAM
suggested changes
Jul 20, 2026
| --cov=esmf_aspect_meta_model_python/ \ | ||
| --cov-fail-under=85 \ | ||
| tests/ \ | ||
| tests/ tests_invalid/ \ |
Contributor
There was a problem hiding this comment.
Thank you for working on these updates. At the moment, all of the tests we rely on to validate the library live in the top-level tests/ suite. To keep things consistent and easier to locate, would you mind moving the updated and corrected tests into the tests/integration/ directory?
In this case, we won't need to make any changes to the tox configuration.
Contributor
Author
There was a problem hiding this comment.
Thank you for the review @Hanna-Shalamitskaya-EPAM, I've just updated the PR in accordance with your comment.
Hanna-Shalamitskaya-EPAM
approved these changes
Jul 29, 2026
Hanna-Shalamitskaya-EPAM
left a comment
Hanna-Shalamitskaya-EPAM
left a comment
Contributor
There was a problem hiding this comment.
Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following fixes to make the existing tests for invalid input pass.
Fixes #75
Type of change
Checklist:
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works