fix: copy CredentialObject ID from received credential offer messages - #1057
Merged
paullatzelsperger merged 2 commits intoAug 12, 2026
Merged
Conversation
jimmarino
approved these changes
Aug 12, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
paullatzelsperger
force-pushed
the
fix/1056-credential-object-id
branch
from
August 12, 2026 13:12
6330414 to
9556c7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Copies the
@idof eachCredentialObjectfrom an incoming DCPCredentialOfferMessageinto the storedCredentialOfferentity in theCredentialOfferApiController.Adds
DcpCredentialOfferApiEndToEndTest, which covers the DCP Credential Offer API (POST /v1/participants/{participantContextId}/offers) end-to-end with an IdentityHub and an IssuerService runtime: the happy path asserts that a received offer is stored and processed, that the offer handler initiates a holder credential request carrying the offered credential object ID, and that the resulting DCP credential request is registered (APPROVED) on the issuer service. Validation and auth error cases (400/401/403) are covered as well, both in-memory and against PostgreSQL.Why it does that
The credential object
@idis the issuer-assigned ID that the holder must reference in the subsequentCredentialRequestMessage. Since it was dropped during mapping, the credential request triggered by an offer referenced a credential object ID the issuer does not know, breaking offer-based issuance.Linked Issue(s)
Closes #1056
🤖 Generated with Claude Code