feat: remove uniqueness constraint from CredentialDefinition - #1046
Merged
Conversation
ndr-brt
force-pushed
the
1045-remove-uniqueness-constraint
branch
from
July 20, 2026 11:59
bb197aa to
fa939cf
Compare
wolf4ood
approved these changes
Jul 20, 2026
ndr-brt
force-pushed
the
1045-remove-uniqueness-constraint
branch
from
July 20, 2026 12:14
fa939cf to
198bd33
Compare
ndr-brt
force-pushed
the
1045-remove-uniqueness-constraint
branch
from
July 20, 2026 12:20
198bd33 to
c2b6520
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Removes uniqueness check on
credentialTypeinCredentialDefinitionWhy it does that
credentials definitions are now accessed by id
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #1045
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.