Skip to content

Fix: compiler warnings #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hasan-htp wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix: compiler warnings #2688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6dc6b3
[ecalhd5] fix Werror type-limits warning, unsigned is always greater …
hasan-htp Jul 23, 2026
869fa9e
[serialization] fix a Werror reorder warning
hasan-htp Jul 23, 2026
fbf66c1
[serialization] fix a Werror non-template-friend
hasan-htp Jul 23, 2026
48309b8
[serialization] fix Werror nonnull
hasan-htp Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions contrib/ecalhdf5/src/eh5_meas_file_v2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,14 +275,10 @@ bool eCAL::eh5::HDF5MeasFileV2::GetEntryData(long long entry_id, void* data) con

if (dataset_id < 0) return false;

auto size = H5Dget_storage_size(dataset_id);

herr_t read_status = -1;
if (size >= 0)
{
read_status = H5Dread(dataset_id, H5T_NATIVE_UCHAR, H5S_ALL, H5S_ALL, H5P_DEFAULT, data);
}

read_status = H5Dread(dataset_id, H5T_NATIVE_UCHAR, H5S_ALL, H5S_ALL, H5P_DEFAULT, data);

H5Dclose(dataset_id);

return (read_status >= 0);
Expand Down
19 changes: 8 additions & 11 deletions contrib/ecalhdf5/src/hdf5_helper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,12 @@ bool ReadStringEntryAsString(hid_t root, const std::string& url, std::string& da
const auto size = H5Dget_storage_size(dataset_id);

herr_t read_status = -1;
if (size >= 0)
{
data.resize(size);
const auto string_data_type = H5Tcopy(H5T_C_S1);
H5Tset_size(string_data_type, size);
read_status = H5Dread(dataset_id, string_data_type, H5S_ALL, H5S_ALL, H5P_DEFAULT, static_cast<void*>(const_cast<char*>(data.data())));
}

data.resize(size);
const auto string_data_type = H5Tcopy(H5T_C_S1);
H5Tset_size(string_data_type, size);
read_status = H5Dread(dataset_id, string_data_type, H5S_ALL, H5S_ALL, H5P_DEFAULT, static_cast<void*>(const_cast<char*>(data.data())));


H5Dclose(dataset_id);
return (read_status >= 0);
Expand Down Expand Up @@ -129,11 +128,9 @@ bool ReadBinaryEntryAsString(hid_t root, const std::string& url, std::string& da
data.resize(size);

herr_t read_status = -1;
if (size >= 0)
{
read_status = H5Dread(dataset_id, H5T_NATIVE_UCHAR, H5S_ALL, H5S_ALL, H5P_DEFAULT, static_cast<void*>(const_cast<char*>(data.data())));
}

read_status = H5Dread(dataset_id, H5T_NATIVE_UCHAR, H5S_ALL, H5S_ALL, H5P_DEFAULT, static_cast<void*>(const_cast<char*>(data.data())));

H5Dclose(dataset_id);
return (read_status >= 0);
}
Expand Down
4 changes: 2 additions & 2 deletions serialization/common/common/include/ecal/msg/imeasurement.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ namespace eCAL
using MessageT = T;

IMessageChannel(IChannel&& binary_channel_)
: m_serializer{std::make_shared<Serializer>()}
, binary_channel(std::move(binary_channel_))
: binary_channel(std::move(binary_channel_))
, m_serializer{std::make_shared<Serializer>()}
{
// We are trying to create a "strong" type, based on only a channel name
// There is a good chance, that the created channel does not match the data
Expand Down
8 changes: 1 addition & 7 deletions serialization/common/common/include/ecal/msg/omeasurement.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ namespace eCAL
template <typename T, typename Serializer>
class OMessageChannel
{
friend OMessageChannel CreateChannel(OMeasurement& meas_, const std::string& channel_name_);

@KerstinKeller KerstinKeller Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this issue a warning? I think we need this friend declaration.

@hasan-htp hasan-htp Aug 3, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function is declared in line 80 as a template function. but this friend declaration itself is not template, this is what giving the warning.
The reason of removing the friend declaration is that the function is only using the constractor of OMessageChannel, which is public.

or am I missing something?


public:
// Should those be private?
using SerializerT = Serializer;
Expand Down Expand Up @@ -57,11 +55,7 @@ namespace eCAL
// The way we handle Publishers requires us to do a two pass serialization;
size_t message_size = m_serializer->MessageSize(entry_.message);
buffer.resize(message_size);
if (message_size == 0)
{
m_serializer->Serialize(entry_.message, nullptr, 0);
}
else
if (message_size > 0)
{
m_serializer->Serialize(entry_.message, static_cast<void*>(&buffer[0]), buffer.size());
}
Expand Down