fix(intent): rollup glue resolves setting-entity child/parent to the Settings perspective - #6351
Merged
Merged
Conversation
…Settings perspective buildRollups resolved childPerspective/parentPerspective with plain resolvePerspective, missing the setting -> "Settings" special-case that buildRelationLinks / putPersonalAssignee already apply. So a roll-up whose child or parent is kind: setting generated a handler importing gen.<mod>.data.<entityname> (which does not exist) instead of gen.<mod>.data.settings - failing javac and, because the client-Java batch is all-or-nothing, taking down every controller in the app. Latent until the first setting-entity roll-up: a Currency (setting) <- CurrencyRate (setting) op: latest roll-up exposed it. Now resolves to the Settings perspective like every other setting-aware builder. GlueRollupLatestTest extended: both fixture entities are kind: setting and the child/parent perspectives assert "Settings". Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildRollupsresolvedchildPerspective/parentPerspectivewith plainresolvePerspective, missing theisSetting() -> "Settings"special-case thatbuildRelationLinksandputPersonalAssigneealready apply. A roll-up whose child or parent iskind: settingtherefore generated a handler importinggen.<mod>.data.<entityname>(nonexistent) instead ofgen.<mod>.data.settings— failing javac, and since the client-Java batch is all-or-nothing, taking down every controller in the app.Latent until the first setting-entity roll-up: a
Currency(setting) ←CurrencyRate(setting)op: latestroll-up (the currenciesCurrency.rateadoption) exposed it.GlueRollupLatestTestextended — both fixture entities arekind: setting; the child/parent perspectives now assert"Settings".Follow-up to #6350; unblocks the KeyFolders currencies
Currency.ratelatest-rollup adoption.🤖 Generated with Claude Code